Skip to content
This repository has been archived by the owner on Aug 2, 2020. It is now read-only.

Keep random delay of media card generation from moving user buttons #152

Open
kmosiejczuk opened this issue Jul 25, 2019 · 1 comment
Open
Labels
A-accessibility (Affects) accessibility C-main-view Main view on web interface (component) E-big (C) Big (effort) to implement K-bug (Kind) is broken feature or functionality that clearly does not do what it should K-fediverse-extensions (Kind) is non-standard fediverse features K-offer-upstream (Kind) is a change that should also be merged into upstream Mastodon P-substantial (A) Substantial (impact) of change V-hotfix-bump Fixes that are important enough to require a hotfix (version) bump

Comments

@kmosiejczuk
Copy link

Often on bsd.network, I will favorite a toot, go to boost or reply to the toot, and then end up clicking on the media card that just popped under my cursor as I clicked.

I have heard the explanation that the delay is because of a random delay inserted into the fetch so the fediverse doesn't DoS the website mentioned. OK.

I'd recommend that either:

Save room for the card to appear so it doesn't move the user buttons.

or

Don't display the toot until the card is generated.

I suppose another alternative would be not to refresh the toot while the mouse buttons is hovering over it.

@clarfonthey
Copy link
Member

Alternatively we could show a placeholder the same size until the card is loaded. Although honestly, I don't know why this logic is in the client instead of on the server.

@clarfonthey clarfonthey added A-accessibility (Affects) accessibility C-main-view Main view on web interface (component) K-bug (Kind) is broken feature or functionality that clearly does not do what it should K-fediverse-extensions (Kind) is non-standard fediverse features K-offer-upstream (Kind) is a change that should also be merged into upstream Mastodon V-hotfix-bump Fixes that are important enough to require a hotfix (version) bump E-big (C) Big (effort) to implement P-substantial (A) Substantial (impact) of change labels Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-accessibility (Affects) accessibility C-main-view Main view on web interface (component) E-big (C) Big (effort) to implement K-bug (Kind) is broken feature or functionality that clearly does not do what it should K-fediverse-extensions (Kind) is non-standard fediverse features K-offer-upstream (Kind) is a change that should also be merged into upstream Mastodon P-substantial (A) Substantial (impact) of change V-hotfix-bump Fixes that are important enough to require a hotfix (version) bump
Development

No branches or pull requests

2 participants