Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sokol_gfx.h: sg_limits should contain a max uniform block size. #777

Open
floooh opened this issue Jan 20, 2023 · 0 comments
Open

sokol_gfx.h: sg_limits should contain a max uniform block size. #777

floooh opened this issue Jan 20, 2023 · 0 comments

Comments

@floooh
Copy link
Owner

floooh commented Jan 20, 2023

E.g. the maximum data size that can be updated with an sg_apply_uniforms() call - this can be down to 16 KByte on mobile GPUs (or even less on very old GLES2 GPUs), so it doesn't make sense to introduce a hardwired limitation.

Then in sg_make_shader(), shader creation should fail if one of the uniform blocks in sg_shader_desc is over the limit, and in addition, the validation function sg_make_shader() should check this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant