Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to have a make.exe in the PATH when building android samples under Windows #136

Open
llzen44 opened this issue Feb 24, 2024 · 1 comment

Comments

@llzen44
Copy link

llzen44 commented Feb 24, 2024

Hi

There is still a need to have make.exe available in the PATH when building android examples under Windows (10).
I tend to have as few as possible in my PATH by default (unlike *nix systems).

Once using the one under fips-sdks\android\ndk-bundle\prebuilt\windows-x86_64\bin, everything is built correctly.

error msg:
[ERROR] build tool(s) make not found

merci

@floooh
Copy link
Owner

floooh commented Feb 25, 2024

I'm not sure if cmake is smart enough to find the make tool inside the android-sdk directory, but it's worth a try I guess.

To try this, you can go into the fips directory and change this function to always return True:

https://github.com/floooh/fips/blob/master/mod/tools/make.py#L12

If the build then works we can easily remove the requirement that make is in the path, otherwise there's not much that can be done I guess.

What I do to prevent PATH pollution on Windows is to install any cmdline tools via scoop: https://scoop.sh/, scoop only adds a single new directory to the PATH, and then puts links to all installed command line tools into this directory.

I would also recommend the ninja tool instead of make (https://bjansen.github.io/scoop-apps/main/ninja/).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants