Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent FIPS_PROJECT_DEPLOY_DIR if cmake project name != directory name #154

Closed
floooh opened this issue Aug 16, 2017 · 2 comments
Closed
Assignees
Labels

Comments

@floooh
Copy link
Owner

floooh commented Aug 16, 2017

Bug: FIPS_PROJECT_DEPLOY_DIR and FIPS_PROJECT_BUILD_DIR use the cmake project name, while the rest of fips uses the directory name as project name.

Solution: the cmake variables also must use the directory name and ignore the cmake project name.

@floooh floooh added the bug label Aug 16, 2017
@floooh floooh self-assigned this Aug 16, 2017
@floooh
Copy link
Owner Author

floooh commented Aug 16, 2017

PS: there are also various other places where CMAKE_PROJECT_NAME is used instead of the directory name, these must be fixed as well.

@floooh
Copy link
Owner Author

floooh commented Aug 16, 2017

This is fixed in commit c02765f

@floooh floooh closed this as completed Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant