Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the dependencies and default settings android injections #1297

Closed
mihaiblaga89 opened this issue Dec 18, 2023 · 2 comments
Closed
Assignees
Milestone

Comments

@mihaiblaga89
Copy link
Contributor

No description provided.

@mihaiblaga89 mihaiblaga89 self-assigned this Dec 18, 2023
@mihaiblaga89 mihaiblaga89 added this to the 1.0 milestone Dec 18, 2023
@pauliusguzas
Copy link
Collaborator

@mihaiblaga89 how should this be tested?

@mihaiblaga89
Copy link
Contributor Author

mihaiblaga89 commented Jan 8, 2024

@pauliusguzas testcases

  • add enableJetifier or enableAndroidX to any android platform, run it, check gradle.properties and you should see these props set to true or false, based on what you set
  • take template-starter renative.json for example. Add this to react-native plugin
"react-native": {
  "version": "0.72.4",
  "android": {
      "implementation": "# TEST_ID_SOMETHING"
  }
},

run it, then you should see TEST in platformBuilds/template_android/app/build.gradle in the dependencies section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants