Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet setup page seems recently bigified #7634

Closed
xpkoala opened this issue Sep 8, 2022 · 1 comment
Closed

Fleet setup page seems recently bigified #7634

xpkoala opened this issue Sep 8, 2022 · 1 comment
Assignees
Labels
bug Something isn't working as documented ~frontend Frontend-related issue. ~legacy-interface-product-group Associated with the legacy "interface" product group. (No longer exists) ~release blocker This story is currently blocking the next release of Fleet from going out.
Milestone

Comments

@xpkoala
Copy link
Contributor

xpkoala commented Sep 8, 2022

Fleet version: main

Operating system: (e.g. macOS 11.2.3)

Web browser: (e.g. Chrome 88.0.4324)


🧑‍💻  Expected behavior

  • There would be ample padding between the user setup and top icon imagery during Fleet setup.
  • The Fleet icon in the top left would be easily readable.

💥  Actual behavior

  • The page seems to have recently had some sizing issues? (I can confirm on 4.19.1 if this doesn't look apparent) This was observed when testing the new error message from this ticket improve messaging when POST /api/v1/setup fails #7245
  • The Fleet icon has shrunk considerably (This occurs across all browsers.)

More info

Screenshot 2022-09-08 at 6 40 37 AM

@xpkoala xpkoala added bug Something isn't working as documented ~frontend Frontend-related issue. ~legacy-interface-product-group Associated with the legacy "interface" product group. (No longer exists) ~release blocker This story is currently blocking the next release of Fleet from going out. labels Sep 8, 2022
@xpkoala xpkoala moved this to 🥚 Ready in 🚀 Release Sep 8, 2022
@ghernandez345
Copy link
Contributor

ghernandez345 commented Sep 8, 2022

@xpkoala the only change made was the logo was made smaller on by accident so I can change that.

The spacing between the breadcrumbs and the form was not changes and the way it works is that the spacing grows and shrink with the height of the browser viewport. So it will not always look the same depending on how high your browser window is.

@ghernandez345 ghernandez345 self-assigned this Sep 8, 2022
@ghernandez345 ghernandez345 moved this from 🥚 Ready to 🐣 In progress in 🚀 Release Sep 8, 2022
@ghernandez345 ghernandez345 moved this from 🐣 In progress to ✨ ‎ ‎In review in 🚀 Release Sep 8, 2022
@ghernandez345 ghernandez345 moved this from ✨ ‎ ‎In review to ✔️ ‎ ‎‎‎Awaiting QA in 🚀 Release Sep 8, 2022
@xpkoala xpkoala moved this from ✔️ ‎ ‎‎‎Awaiting QA to ✅ Ready for release in 🚀 Release Sep 8, 2022
@lukeheath lukeheath added this to the 4.20.0 milestone Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as documented ~frontend Frontend-related issue. ~legacy-interface-product-group Associated with the legacy "interface" product group. (No longer exists) ~release blocker This story is currently blocking the next release of Fleet from going out.
Development

No branches or pull requests

3 participants