Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL statement debug logging is incomplete #23884

Open
iansltx opened this issue Nov 16, 2024 · 0 comments
Open

SQL statement debug logging is incomplete #23884

iansltx opened this issue Nov 16, 2024 · 0 comments
Labels
~backend Backend-related issue. bug Something isn't working as documented ~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook.

Comments

@iansltx
Copy link
Member

iansltx commented Nov 16, 2024

💥  Actual behavior

Debug logging of SQL statements doesn't cover all statements.

🧑‍💻  Steps to reproduce

  1. Run Fleet with FLEET_DEV_ENABLE_SQL_INTERCEPTOR=1
  2. Run e.g. the hosts list endpoint
  3. Notice that there are fewer database queries logged than you would expect

🕯️ More info

The interception code here is an undocumented WIP. It's just as well that it's undocumented at this point, but the feature is quite useful for tracing through endpoint executions for performance or correctness tracking, so ideally we just make it work with more/all of our MySQL calls

@iansltx iansltx added #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. bug Something isn't working as documented ~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. ~backend Backend-related issue. labels Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~backend Backend-related issue. bug Something isn't working as documented ~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook.
Development

No branches or pull requests

1 participant