Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbered lists are obstructed past 100 #417

Open
maelchiotti opened this issue Sep 1, 2024 · 14 comments
Open

Numbered lists are obstructed past 100 #417

maelchiotti opened this issue Sep 1, 2024 · 14 comments
Labels
enhancement New feature or request

Comments

@maelchiotti
Copy link
Contributor

Items over 100 in numbered lists seem to lack the space to display properly.

Steps to Reproduce

Create a numbered list with 100+ items.

Environment

  • OS: Android
  • Flutter version: 3.22
  • Fleather version: 1.18.0

Screenshot_2024-09-01-14-20-39-681_com.maelchiotti.localmaterialnotes.jpg

@amantoux
Copy link
Member

amantoux commented Sep 4, 2024

Thanks @maelchiotti
One question arises naturally: given that we need to limit the number of items at some number of digits, what should be the limit?
Would 3 digits be enough? (personally I would've thought 2 was enough, but it seems you have a use case with more than 99 items)

@maelchiotti
Copy link
Contributor Author

I do also think 2 digits should be enough, but indeed I didn't ask myself that question.

The user that reported the issue in my app seems to have make a list of anime he watched, but I don't see why he couldn't use an unordered list for that.

I'm okay with keeping the 2 digits limit and informing him about it.

@Amir-P
Copy link
Member

Amir-P commented Sep 4, 2024

I think it is possible to dynamically increase the number of digits in numbered list (with node's children count). What do you think? Would there be any problems in adopting this approach? @amantoux @maelchiotti

@maelchiotti
Copy link
Contributor Author

That would fix the issue indeed.

@amantoux
Copy link
Member

amantoux commented Sep 4, 2024

We can easily find a solution, the question is whether it is worth to add complexity to handle the use case

@Amir-P
Copy link
Member

Amir-P commented Sep 4, 2024

To answer that question we would need user study. But when an app with 100 downloads has a user that needs it, I think it's something that should be addressed since it's also quite easy to do. @amantoux

Another solution would be to remove digit limitations and align numbers to start (left in LTR). This is how Google Docs and Word handle it.

@amantoux
Copy link
Member

amantoux commented Sep 4, 2024

@Amir-P then how many digits does your easy solution support?

@Amir-P
Copy link
Member

Amir-P commented Sep 4, 2024

@Amir-P this how many digits does you easy solution support?

I didn't get that Alan. Could you elaborate on that please? @amantoux

@amantoux
Copy link
Member

amantoux commented Sep 4, 2024

There was a typo, maybe clearer now.

From a UI perspective, I guess supporting many digits can be challenging, even if we dynamically handle the space allocated to the numbering. So, my question is still the same, how much digits do we want to support?

@amantoux
Copy link
Member

amantoux commented Sep 4, 2024

Since you were mentioning Google, this is what I get with more than 100 items
image
Not sure it should serve as an example to follow 😀

The same behaviour is observed in Word

Maybe we should simply not allow more than 99 (or 9999 or whatever we had in mind for the easy solution)

@Amir-P
Copy link
Member

Amir-P commented Sep 4, 2024

Not sure it should serve as an example to follow 😀

Yeah, I noticed the same thing. 😀 I'm sure we can do better! @amantoux

From a UI perspective, I guess supporting many digits can be challenging, even if we dynamically handle the space allocated to the numbering. So, my question is still the same, how much digits do we want to support?

Let me experiment with some options and I'll get back to you. I might find the time on the weekend.

@amantoux
Copy link
Member

amantoux commented Sep 4, 2024

Not sure we should try to do better TBH
My guess is that Google and MS product managers have decided it wasn't worth their time (and I tend to agree with them)

@maelchiotti
Copy link
Contributor Author

maelchiotti commented Sep 4, 2024

While it would be great to allow for an infinite ordered list that automatically gives the digits the space needed, I wouldn't consider this feature a priority for my app.

@Amir-P
Copy link
Member

Amir-P commented Sep 8, 2024

Then let's keep it open for fixing in the future. What do you say? @amantoux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants