Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bump min flutter version to 3.27.0, fix deprecations #1994

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

JaffaKetchup
Copy link
Member

@JaffaKetchup JaffaKetchup commented Nov 24, 2024

Colors are changing in 3.27: https://docs.flutter.dev/release/breaking-changes/wide-gamut-framework.

Not released yet, so no need to worry about merging just yet.

Fixed documentation issues
@JaffaKetchup JaffaKetchup changed the title chore(example): fixed deprecations from Flutter 3.26 chore(example): fixed deprecations from Flutter 3.27 Dec 12, 2024
@monsieurtanuki
Copy link
Contributor

@JaffaKetchup Maybe it's time now, cf. https://github.com/fleaflet/flutter_map/actions/runs/12331534552/job/34418263958

image

@josxha josxha marked this pull request as ready for review December 14, 2024 17:17
@josxha josxha self-requested a review December 14, 2024 17:18
@josxha josxha changed the title chore(example): fixed deprecations from Flutter 3.27 refactor: fix deprecations from Flutter 3.27, bump min flutter version to 3.27.0 Dec 14, 2024
@josxha
Copy link
Contributor

josxha commented Dec 14, 2024

Two additional changes:

  • I removed the used workflow action to check the package score with cli commands as it didn't used the latest flutter version.
  • The new methods that deprecated old flutter api isn't available in previous versions. That's why I bumped the minimum flutter version to 3.27 and with it the minimum dart version to 3.6.0. (new dart functionalities have been unlocked😮)

@josxha josxha changed the title refactor: fix deprecations from Flutter 3.27, bump min flutter version to 3.27.0 refactor: bump min flutter version to 3.27.0, fix deprecations Dec 14, 2024
@josxha josxha merged commit af478f9 into master Dec 14, 2024
7 checks passed
@josxha josxha deleted the clean-deprecations branch December 14, 2024 17:47
@corepuncher
Copy link

Regarding requiring 3.27 for next flutter_map version, I am currently experiencing GPU OOM crashes on Android. iOS seem ok.

I downgraded back to 3.24.5, and the crashes went away. At first I thought it was Impeller-induced on Android, but even after adding the impeller-disabling block to my AndroidManifest.xml, it would still crash, so there must be something GPU/memory related OTHER than "straight impeller" that is causing this. Just something to be aware of.

I am currently working on better memory management to mitigate these crashes. Your OverlayImage PR seems promising because PART of my issues are those.

@monsieurtanuki
Copy link
Contributor

Given that new flutter versions may be problematic, a solution would be to (virtually) downgrade flutter_map to 3.24 and handle the "deprecated" messages with lousy "ignore" comments.
This way developers would be able to use both 3.24 and 3.27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants