Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add image to pubspec.yaml #1830

Closed
wants to merge 3 commits into from

Conversation

josxha
Copy link
Contributor

@josxha josxha commented Feb 16, 2024

This pr is a proposal to add the fm logo as image to the pubspec.yaml file.

The result would look similar to here and further improve the package visibility on pub.dev:
image

The image resolution is currently in this pr only 200x200px as this was the biggest that I could find.

@josxha josxha added this to the v7.0 milestone Feb 16, 2024
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I unfortunately lost the original design files and high quality export. Might need to change it at some point soon anyway, but don't really have any ideas.

Also just be aware that this is not recommended practise, but I'm fine with it:

Don't include logos or other branding imagery in this section.

@josxha
Copy link
Contributor Author

josxha commented Feb 19, 2024

Also just be aware that this is not recommended practise, but I'm fine with it.

Yep, red that too but tbh I think the logo fits better than some ordinary screenshot. 😄

Do you have an idea why the pana score fails?

0/10 points: Package has an example and has no issues with screenshots\n\nFound 4 issues. Showing the first 2:\n\n* /tmp/pana_TLPLCL/./images/logo.webp: Tried interpreting screenshot as WebP with webpinfo \"/tmp/pana_TLPLCL/./images/logo.webp\" failed with exit code 2.\n* /tmp/pana_TLPLCL/./images/logo.webp: Converting screenshot with cwebp \"/tmp/pana_TLPLCL/./images/logo.webp\" -o \"/tmp/ICOKKH/gen/logo.webp\" failed with exit code 2.

@JaffaKetchup
Copy link
Member

"summary": "### [] 0/10 points: Package has an example and has no issues with screenshots\n\nFound 4 issues. Showing the first 2:\n\n /tmp/pana_TLPLCL/./images/logo.webp: Tried interpreting screenshot as WebP with webpinfo \"/tmp/pana_TLPLCL/./images/logo.webp\" failed with exit code 2.\n* /tmp/pana_TLPLCL/./images/logo.webp: Converting screenshot with cwebp \"/tmp/pana_TLPLCL/./images/logo.webp\" -o \"/tmp/ICOKKH/gen/logo.webp\" failed with exit code 2."

Not sure what to make from that.

@josxha
Copy link
Contributor Author

josxha commented Feb 22, 2024

Closing this pr, because of the valid concerns with the current fleaflet logo. Need to revisit once we have one.

@josxha josxha closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants