Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] default to html5 parsing #239

Closed
wants to merge 4 commits into from
Closed

[draft] default to html5 parsing #239

wants to merge 4 commits into from

Commits on May 30, 2022

  1. test: make the generated tests more flexible 

    allow us to add sanitized values with arbitrary keys to the data file
    @flavorjones
    flavorjones committed May 30, 2022
    Configuration menu
    Copy the full SHA
    2d292b8 View commit details
    Browse the repository at this point in the history

  2. feat: scrub attributes before scrubbing the node 

    this removes noisy bad attributes from output for unsafe nodes that
are being escaped
    @flavorjones
    flavorjones committed May 30, 2022
    Configuration menu
    Copy the full SHA
    f91bbce View commit details
    Browse the repository at this point in the history

  3. use nokogiri main for testing purposes

    @flavorjones
    flavorjones committed May 30, 2022
    Configuration menu
    Copy the full SHA
    bc7b362 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. feat: use Nokogiri::HTML5 (libgumbo) by default 

    Note that there is an escape hatch which is to set the environment
variable LOOFAH_HTML4_MODE to return to the previous behavior.

CI tests both html4 and html5 modes
    @flavorjones
    flavorjones committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    8b75439 View commit details
    Browse the repository at this point in the history