Fix metadata of final gemspec #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi - thanks for submitting this. Although these changes seem reasonable, I'm not entirely sure I agree with Hoe in tightly coupling the README with the gemspec. Currently wrestling with better ways to do this, for example, see sparklemotion/nokogiri@06c0ca2 |
JuanitoFatas
force-pushed
the
fix-metadata
branch
from
ed53602
to
6e26a30
Compare
|
I updated this Pull Request as per sparklemotion/nokogiri@06c0ca2. Feel free to close if you have other preferences. Happy Friday! |
|
Hi @JuanitoFatas - thanks much for this! Merging. |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#170 added metadata to the
loofah.gemspec. These changes should be made to README. The::syntax is recommended by seattlerb/hoe@e23f980.This Pull Request is pending with seattlerb/hoe#98 to have metadata uri support for
wiki_uriandmailing_list_uri.