Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should handle <javascript>alert('evil')</javascript> #17

Closed
jpignata opened this issue Feb 1, 2010 · 6 comments
Closed

should handle <javascript>alert('evil')</javascript> #17

jpignata opened this issue Feb 1, 2010 · 6 comments

Comments

@jpignata
Copy link

jpignata commented Feb 1, 2010 

  obj = Object.new(:text => "<javascript>alert('evil')</javascript>")
  obj.valid?
  obj.text.should == "alert('evil')"

 expected: "alert('evil')",
 got: "<javascript>alert('evil')</javascript>" (using ==)
@jpignata
Copy link
Author

jpignata commented Feb 1, 2010

(jp should not leave himself logged into github at work) ;-)

@flavorjones
Copy link
Owner

Indeedly doodly. Will take a look.

@flavorjones
Copy link
Owner

XssFoliate correctly escapes html entities when stripping text from implicitly-scrubbed fields. Closed by 03e781b.

@flavorjones
Copy link
Owner

Note that the behavior now is to return the string containing the entities. This is safe, albeit perhaps not the ideal behavior.

@flavorjones
Copy link
Owner

Fixed the fix with commit 36d583f

@flavorjones
Copy link
Owner

whoops. better to just upgrade to 0.4.6. I feel shame.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flavorjones @jpignata