Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there any reason for excluding controls attribute on audio element from whitelist? #153

Open
dotneet opened this issue Sep 8, 2018 · 2 comments
Open

Is there any reason for excluding controls attribute on audio element from whitelist? #153

dotneet opened this issue Sep 8, 2018 · 2 comments
Labels
allowlist issues related to what tags or attributes are allowed
Milestone
v3.0.0

Comments

@dotneet
Copy link

dotneet commented Sep 8, 2018

I can't find the vulnerability on controls attribute.
any reason for excluding it from whitelist?
@dotneet dotneet changed the title Is there any reason controls attribute on audio element can't be used? Is there any reason for excluding controls attribute on audio element from whitelist? Sep 8, 2018
@flavorjones flavorjones added the allowlist issues related to what tags or attributes are allowed label Oct 27, 2018
@flavorjones
Copy link
Owner

Noting here for posterity that this would be addressed by #155 if we used DOMPurify's allowlists.

@flavorjones
Copy link
Owner

(Assuming you mean the SVG audio element?)

@flavorjones flavorjones added this to the v3.0.0 milestone Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
allowlist issues related to what tags or attributes are allowed
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
2 participants
@flavorjones @dotneet