Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpak-pip-checker should parse python_version synatx in requirements file #365

Open
bbhtt opened this issue Aug 13, 2023 · 1 comment
Open

Comments

@bbhtt
Copy link
Contributor

bbhtt commented Aug 13, 2023

flatpak-builder version

1.3.3

Linux distribution and version

Fedora 38

Affected flatpak-builder tool

pip/flatpak-pip-generator

flatpak-builder tool cli args

NA

Source repository URL

NA

Flatpak-builder manifest URL

NA

Description

Pip checker should parse python_version in requirements file:

dataclasses == 0.8; python_version < "3.7"

and skip downloading a package if the package is not available for a specified python version.

@bbhtt bbhtt added the bug label Aug 13, 2023
@bbhtt
Copy link
Contributor Author

bbhtt commented Aug 17, 2023

Since, the versions of python included in manifest or runtime are already known beforehand, as a temporary solution --ignore-pkg can be used to skip those lines in requirements.txt #364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants