Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Logger#transports length check upon Logger#log #404

Closed
wants to merge 1 commit into from
Closed

fix Logger#transports length check upon Logger#log #404

wants to merge 1 commit into from

Conversation

adriano-di-giovanni
Copy link
Contributor

Logger#transports seems to be an object so there's no length property to test if transports were defined.
Used Object.keys(Logger#transports).length instead.

@indexzero
Copy link
Member

This is correct. Will go into [email protected]

@indexzero
Copy link
Member

We should have a failing test for this though.

indexzero added a commit that referenced this pull request Oct 6, 2014
@indexzero
[test] Added failing tests for #404.
9b1edd6
indexzero added a commit that referenced this pull request Oct 6, 2014
@indexzero
[test fix] Update failing test for #404 to be correct.
3667363
@indexzero
Copy link
Member

Cherry-picked in 549dc33

@indexzero indexzero closed this Oct 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriano-di-giovanni @indexzero