correctly retrieve falsy values from memory (hence file)

indexzero · May 22, 2011 · faa8ab9 · faa8ab9
1 parent e26bbe2
commit faa8ab9
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/lib/nconf/stores/memory.js b/lib/nconf/stores/memory.js
@@ -36,7 +36,7 @@ Memory.prototype.get = function (key) {
   //
   while (path.length > 0) {
     key = path.shift();
-    if (!target[key]) {
+    if (!(target && key in target)) {
       return;
     }
 

diff --git a/test/file-store-test.js b/test/file-store-test.js
@@ -63,11 +63,19 @@ vows.describe('nconf/stores/file').addBatch({
     "the set() method": {
       "should respond with true": function () {
         assert.isTrue(store.set('foo:bar:bazz', 'buzz'));
+        assert.isTrue(store.set('falsy:number', 0));
+        assert.isTrue(store.set('falsy:string', ''));
+        assert.isTrue(store.set('falsy:boolean', false));
+        assert.isTrue(store.set('falsy:object', null));
       }
     },
     "the get() method": {
       "should respond with the correct value": function () {
         assert.equal(store.get('foo:bar:bazz'), 'buzz');
+        assert.equal(store.get('falsy:number'), 0);
+        assert.equal(store.get('falsy:string'), '');
+        assert.equal(store.get('falsy:boolean'), false);
+        assert.equal(store.get('falsy:object'), null);
       }
     },
     "the clear() method": {

diff --git a/test/memory-store-test.js b/test/memory-store-test.js
@@ -15,11 +15,19 @@ vows.describe('nconf/stores/memory').addBatch({
     "the set() method": {
       "should respond with true": function (store) {
         assert.isTrue(store.set('foo:bar:bazz', 'buzz'));
+        assert.isTrue(store.set('falsy:number', 0));
+        assert.isTrue(store.set('falsy:string', ''));
+        assert.isTrue(store.set('falsy:boolean', false));
+        assert.isTrue(store.set('falsy:object', null));
       }
     },
     "the get() method": {
       "should respond with the correct value": function (store) {
         assert.equal(store.get('foo:bar:bazz'), 'buzz');
+        assert.equal(store.get('falsy:number'), 0);
+        assert.equal(store.get('falsy:string'), '');
+        assert.equal(store.get('falsy:boolean'), false);
+        assert.equal(store.get('falsy:object'), null);
       }
     },
     "the clear() method": {