Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Visual Studio Code OSS file dialog bug #38

Open
tapir opened this issue Apr 6, 2019 · 14 comments
Open

Visual Studio Code OSS file dialog bug #38

tapir opened this issue Apr 6, 2019 · 14 comments

Comments

@tapir
Copy link

tapir commented Apr 6, 2019

VSCode OSS's file dialog doesn't adhere to global Gnome theme, nor does it show the bookmarks

@TingPing TingPing transferred this issue from flathub/flathub Apr 9, 2019
@amtlib-dot-dll
Copy link
Collaborator

I think that it's time to upgrade to the latest runtime

@tapir
Copy link
Author

tapir commented Apr 10, 2019

You mean that it's fixed now or I was using an out dated runtime?

@amtlib-dot-dll
Copy link
Collaborator

I've upgraded the runtime to the latest one, please try it and tell us whether your problem still exists.

@tapir
Copy link
Author

tapir commented Apr 12, 2019

The problem still persists. File dialog is still not adhering to the dark theme like all other apps and it doesn't show nautilus bookmarks.

@amtlib-dot-dll
Copy link
Collaborator

Will the proprietary version https://github.com/flathub/com.visualstudio.code have the same issue?

@tapir
Copy link
Author

tapir commented Apr 14, 2019

The proprietary version is the same

@amtlib-dot-dll
Copy link
Collaborator

That's weird. I wish there would be a GNOME developer answering where GNOME file dialog stores the "Recent" data

@tapir
Copy link
Author

tapir commented Apr 15, 2019

It's not recent data though. It's bookmarks. People can explicitly set bookmarks on nautilus and it will show in the file dialog as well.

Also the the theme. So I'm guessing it doesn't use user's nautilus settings at all.

@amtlib-dot-dll
Copy link
Collaborator

Perhaps. Would you give us some examples of Flatpak applications which can read nautilus settings? BTW, I am curious about whether Visual Studio Code outside Flatpak read those data

@tapir
Copy link
Author

tapir commented Apr 15, 2019

All the gnome apps can use them. From flathub I'm using gnome-books, gnome-notes, gnome-documents, etc... And yes the vscode from arch linux repo does use the global settings as well.

@amtlib-dot-dll
Copy link
Collaborator

amtlib-dot-dll commented Apr 15, 2019

Try this?

flatpak run --filesystem=xdg-run/dconf --filesystem=~/.config/dconf:ro --talk-name=ca.desrt.dconf --env=DCONF_USER_CONFIG_DIR=.config/dconf com.visualstudio.code.oss

Well it seems not working 🤔

@tapir
Copy link
Author

tapir commented Apr 15, 2019

unfortunately no

@tapir
Copy link
Author

tapir commented Apr 15, 2019

I don't know if this helps but from the flatpak website: "Portals"

Examples of capabilities that can be accessed through portals include opening files through a file chooser dialog, or printing. Interface toolkits can implement transparent support for portals, so access to resources outside of the sandbox will work securely and out of the box.

@amtlib-dot-dll
Copy link
Collaborator

Visual Studio Code does not use Portals, and many other non-GNOME applications have the same issue. Stay tuned

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants