Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling of update-format-crau #28

Closed
1 of 2 tasks
dongsupark opened this issue Nov 16, 2023 · 3 comments
Closed
1 of 2 tasks

Improve error handling of update-format-crau #28

dongsupark opened this issue Nov 16, 2023 · 3 comments
Labels
kind/feature A feature request.

Comments

@dongsupark
Copy link
Member

dongsupark commented Nov 16, 2023

  • Currently parse_signature_data and verify_sig_pubkey return Option instead of Result. That was written for simplicity. But we are seeing more cases where clearer error handling with Result is needed.
    /cc @wrl

  • the dummy signature error is printed too prominently, we skip over it but it looks like the program crashed if you don't pay attention to the last line

Parsed and verified signature data from file "/var/tmp/outdir/.unverified/oem-ami.gz"

which indicates that it was successful.
(suggested by @pothos)

@pothos
Copy link
Member

pothos commented Nov 20, 2023

The comment is here: #23 (comment)

@dongsupark
Copy link
Member Author

The 1st issue was done by #30

@pothos
Copy link
Member

pothos commented Nov 27, 2023

The anyhow PR removed the printing of the signature error, we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A feature request.
Projects
None yet
Development

No branches or pull requests

2 participants