-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure updates #1950
azure updates #1950
Conversation
...src/third_party/coreos-overlay/app-emulation/wa-linux-agent/files/0001-flatcar-changes.patch
Outdated
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/coreos-base/coreos/coreos-0.0.1.ebuild
Show resolved
Hide resolved
...r/src/third_party/coreos-overlay/app-admin/azure-nvme-utils/azure-nvme-utils-0.0.0-r1.ebuild
Outdated
Show resolved
Hide resolved
...src/third_party/coreos-overlay/app-emulation/wa-linux-agent/files/0001-flatcar-changes.patch
Outdated
Show resolved
Hide resolved
b053fef
to
74e5a90
Compare
When CoreosCommonUtil was factored out, we missed updating the class name in a call to super(). This results in an error when executing `/usr/sbin/waagent -force -deprovision+user`. Fix the class name. Create a compatibility symlink at the old config file location (/usr/share/oem/waagent.conf) to handle the case of enabling auto-updates on the agent. The upstream version of the agent does not have our downstream patch so doesn't know about the updated config file location. We should upstream our changes. Signed-off-by: Jeremi Piotrowski <[email protected]>
Flatcar prepares /etc/hostname from the initrd through afterburn. After switching root, systemd-networkd fetches a dhcp lease with the correct hostname already. This publishes the hostname to the vnet DNS server as well. When WALinuxAgent starts, it tries to do the same steps: configure the hostname, bounce the link to force dhcp lease renewal. This has caused issues in the past with multi-nic configurations but also with networked services that are trying to use the network (etcd/flanneld). The link bouncing by WALinuxAgent is not necessary because of Flatcars boot design, so return without bouncing the link. Tested that DNS from other VMs in the same vnet works. Signed-off-by: Jeremi Piotrowski <[email protected]>
This is a new package that is being developed to handle providing symlinks for nvme disks (os,data,temporary) on newer Azure instances. It needs to be part of the OS, and not oem-azure, because it carries udev rules. Signed-off-by: Jeremi Piotrowski <[email protected]>
74e5a90
to
7a1a004
Compare
Build action triggered: https://github.com/flatcar/scripts/actions/runs/8940052744 |
Do you mean live changing through the Azure API without a reboot? Sounds like previously this resulted in a transient hostname being set, i.e., Not sure if it's good to revert because preventing the network restart was also meant as bug fix, or? What we could try is to see whether we can trigger a new DHCP request instead of the if-up-down hack. My naive thinking is that the DHCP request would keep the same IP address and be a no-op except that it transfers the hostname to systemd-networkd. I guess |
Looks like it's the other way round, changing internally and waagent noticed this and issues the if-up-down to propagate to the read-only VM properties.
Apparently they do not but |
Opened a PR #1978 |
Different topic: For the deprovisioning to work despite |
azure updates
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
Testing here: http://jenkins.infra.kinvolk.io:8080/job/container/job/test/22112/cldsv/
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.