-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
e7e45c2
to
1f30c39
Compare
bb50d62
to
ca212b2
Compare
ca212b2
to
a9c7995
Compare
0ce1e1d
to
8114d55
Compare
CI passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good.
We would still need changelogs for the package updates.
There is already a changelog - https://github.com/flatcar-linux/portage-stable/pull/246/files#diff-6a01b3f753a3e3d2020766b79d5e301b0e2d9a2c159c29c2d58bf2e82e10ca64 (if the link doesn't work because of updated PR, then searching for |
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit cc0a525e9480ee93ccc6c06cde2ade0ce9bfcb46.
It's from gentoo commit 881172c797de03a2d304ca200605ac9fa8f7df63.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 77ac7cb548198f5386113e973b6402f4a282151c.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 6b27b725d5f53a9c1d95166e08187dda38601512.
It's from gentoo commit a509bfbd3e031b49977408b11f10e5e7220e5b0e.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 3108dda67f197a3dad11085e66442075b6d890a2.
It's from gentoo commit fba553267b6b1e31da713a91b001b429ebf24510.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 9f3688c9376c6ea284464659c69d4cf8cb5ae84f.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 1e963ad3f4dad5e68fb4c4571ed70e4735a407a4.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
54b3b98
to
66b76b0
Compare
Thanks, looks good to me. |
Sure. Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last question - otherwise it looks really good to me. 🚀
Please see the commits to see what packages got updated. I also dropped two eclasses that weren't used anywhere.
Should be merged together with flatcar-archive/coreos-overlay#1413.
CI: http://localhost:9091/job/os/job/manifest/4408/cldsv/