Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Flarum Util slug to Laravel slug #1875

Closed
wants to merge 6 commits into from

Conversation

thanhtaivtt
Copy link

Changes proposed in this pull request:

Fix the issue of some non-ASCII characters disappearing from the slugs.

  • In the backend I replaced Str Flarum Util to Str Laravel.
  • In fontend I have added some UTF-8 variant characters.

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run php vendor/bin/phpunit).

@franzliedke
Copy link
Contributor

Hi, and thanks for your PR!

Fix the issue of some non-ASCII characters disappearing from the slugs.

Could you explain which issue you're referring to? Is there a link where this is explained in more detail?


Also, please explain the JS changes. Where does that code come from?

@thanhtaivtt
Copy link
Author

Hi!

The problem that I encountered is related to converting title to slug in my language (Vietnamese) and some other languages such as Russian, German, French, ... And it was mentioned in issuse #194

My javascript code is developed on gist Slugify makes a string URI-friendly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants