Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accentuated characters break the link to a user #767

Closed
Averell7 opened this issue Jan 28, 2016 · 1 comment
Closed

Accentuated characters break the link to a user #767

Averell7 opened this issue Jan 28, 2016 · 1 comment

Comments

@Averell7
Copy link

Although this bug is related to : Slug transliteration #194, I create a new issue because it is really different, it is a question of transliteration only (I may be wrong on that point)

Suppose the user : Béatrice
In a message, you want to create a link to her message :
@béatrice#12

In the text, you will see : @béatrice#12, and the link is not created.

The reason is transliteration.
Transliteration is used for user names. Try :
Create a user : Beatrice
Try to change it to : Béatrice. Refused with message : User name already in use.
Try in two steps :

  1. Change Beatrice to Béatrice1
  2. Change Béatrice1 to Béatrice
    It works.

New test :

  1. User Beatrice (without accent). Create a message with a link to Beatrice.
  2. Change Beatrice to Béatrice : The previously created link continues to work, but you cannot create a new link to Béatrice. The working link is written :
    <a href="/d/7/43" class="PostMention" data-id="68">Beatrice</a>
    In the texte it appears like : Beatrice (without accent)

If you let the mouse on the link, you will see in the popup : "Béatrice : Blablabla..." with accent on Béatrice.

This mixing of two types of representation of the user (with or without accent) is the reason of the bug.

Solution : when creating a link to user, use the same type or transliteration which is used when creating the references to the posts.

@tobyzerner
Copy link
Contributor

Thanks for the report. As discussed in #832 and #557, we've made a decision to disallow non-ASCII characters in usernames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants