Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned pullout keeps scrolling back to the beginning #2582

Closed
harry-wg opened this issue Jan 28, 2021 · 1 comment
Closed

Pinned pullout keeps scrolling back to the beginning #2582

harry-wg opened this issue Jan 28, 2021 · 1 comment
Milestone

Comments

@harry-wg
Copy link

Bug Report

Current Behavior
Whenever I select a message from the pinned pullout, the correct message is displayed alongside the pullout. But the pullout immediately scrolls back to the top message instead of maintaining the pullout's correct vertical scroll position

Steps to Reproduce

  1. Go to https://discuss.flarum.org/
  2. Click on the first visible post
  3. If the pinned pullout is not visible, open it and pin it
  4. Still in the pinned pullout, scroll it down by a couple of screens
  5. Click on a thread title in the pullout
  6. Observe that the associated message is correctly displayed alongside the pullout
  7. Error: observe that the thread title you clicked on is no longer visible -- the pullout has scrolled back to the top

Expected Behaviour
The behaviour in previous versions is correct -- ie, the pinned pullout does not scroll back to the top when selecting a thread from the pullout

Screenshots
You can optionally see the above steps in a video at [https://vimeo.com/505898276](https://vimeo.com/505898276

Environment

  • Flarum version: As far as I can see, you don't mention this at https://discuss.flarum.org/ -- maybe you should?
  • Website URL: as above
  • Webserver: as above
  • Hosting environment: as above
  • PHP version: as above
  • Browser: Firefox 85.0 64 bit in windows 10
@askvortsov1
Copy link
Member

Fixed in #2402. Now we have an issue for it, thanks!

@askvortsov1 askvortsov1 added this to the 0.1.0-beta.16 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants