Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error alert in modal remains after request succeeds #1892

Closed
dsevillamartin opened this issue Sep 23, 2019 · 1 comment · Fixed by #2467
Closed

Error alert in modal remains after request succeeds #1892

dsevillamartin opened this issue Sep 23, 2019 · 1 comment · Fixed by #2467
Labels
Good first issue Hacktoberfest type/bug

Comments

@dsevillamartin
Copy link
Member

Bug Report

Current Behavior
Errors handled with the modal handing that shows an Alert of type error remain after the request succeeds. I don't think there's a method to reset that, probably simply setting this.alert = null would be fine.

Steps to Reproduce

  1. Open change email modal
  2. Change email
  3. Input wrong password
  4. Input correct password

Expected Behavior
Error message disappears.

Screenshots
image
image

Possible Solution
Simply set this.alert = null; or add a method that does this - easier for extension developers to know it exists and use it.
@azibom azibom mentioned this issue Nov 25, 2020
Merged
@azibom
Copy link
Contributor

azibom commented Nov 25, 2020

Hi
I fixed it link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Hacktoberfest type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix the ui modal problem in the change email azibom/core
3 participants
@dsevillamartin @azibom @askvortsov1