Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GetDisplayName to User namespace #1742

Closed
luceos opened this issue Feb 1, 2019 · 3 comments · Fixed by #1768
Closed

Move GetDisplayName to User namespace #1742

luceos opened this issue Feb 1, 2019 · 3 comments · Fixed by #1768

Comments

@luceos
Copy link
Member

luceos commented Feb 1, 2019

The GetDisplayName event is stored under the src/Event, this is incorrect. The event is purely in use for the Flarum/User namespace and as such should be moved to Flarum/User/Event.

All related code has to change and a changelog item should be created.

@franzliedke
Copy link
Contributor

Not really necesary, IMO. All events under Flarum\Event should basically be considered deprecated - their use cases are all meant to be covered by extenders.

@tobyzerner
Copy link
Contributor

But I suppose assuming we do add an extender for this, the internal GetDisplayName event should still be moved to the User namespace

@luceos
Copy link
Member Author

luceos commented Mar 28, 2019

This issue is indeed about the location of the event. As it is related to the user it should be moved under that namespace, not the global Flarum one where eventually no events should remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants