Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'oldUsername' to User\Event\Renamed #1563

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Add 'oldUsername' to User\Event\Renamed #1563

merged 1 commit into from
Sep 3, 2018

Conversation

dsevillamartin
Copy link
Member

Changes proposed in this pull request:

  • Add $oldUsername to User\Event\Renamed
    • Allows to act on old & new after renaming
    • Maintains consistency with Discussion\Event\Renamed

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run php vendor/bin/phpunit).

@franzliedke franzliedke merged commit 43fc2c0 into flarum:master Sep 3, 2018
@dsevillamartin dsevillamartin deleted the user-renamed-provide-old-username branch September 3, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants