Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console configuration event #1349

Merged
merged 2 commits into from
Feb 7, 2018

Conversation

clarkwinkelmann
Copy link
Member

@clarkwinkelmann clarkwinkelmann commented Jan 24, 2018

This is based on the work previously done in https://github.com/flagrow/console

I'm not sure if having a reference to Flarum\Foundation\Application in the event is necessary. I remember there was no way to access it otherwise in beta7, but maybe this has changed in beta8 (use case: get the version or the path of the application when registering a command).

Adding this event will allow extensions to hook into the commands offered by php flarum

@luceos
Copy link
Member

luceos commented Jan 25, 2018

I like this very much, this would reduce the code necessary for our console package.

@tobyzerner tobyzerner merged commit 636e965 into flarum:master Feb 7, 2018
@tobyzerner
Copy link
Contributor

Thanks @clarkwinkelmann!

@luceos luceos added this to the 0.1.0-beta.8 milestone Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants