Performance: Load only basic information about terminal/relevant posts

flarum · Nov 11, 2017 · dedcbae · dedcbae
1 parent 9cc67fe
commit dedcbae
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 11 deletions.
diff --git a/src/Api/Serializer/DiscussionBasicSerializer.php b/src/Api/Serializer/DiscussionBasicSerializer.php
@@ -54,7 +54,7 @@ protected function startUser($discussion)
      */
     protected function startPost($discussion)
     {
-        return $this->hasOne($discussion, 'Flarum\Api\Serializer\PostSerializer');
+        return $this->hasOne($discussion, 'Flarum\Api\Serializer\PostBasicSerializer');
     }
 
     /**
@@ -70,7 +70,7 @@ protected function lastUser($discussion)
      */
     protected function lastPost($discussion)
     {
-        return $this->hasOne($discussion, 'Flarum\Api\Serializer\PostSerializer');
+        return $this->hasOne($discussion, 'Flarum\Api\Serializer\PostBasicSerializer');
     }
 
     /**
@@ -86,6 +86,14 @@ protected function posts($discussion)
      */
     protected function relevantPosts($discussion)
     {
-        return $this->hasMany($discussion, 'Flarum\Api\Serializer\PostSerializer');
+        return $this->hasMany($discussion, 'Flarum\Api\Serializer\PostBasicSerializer');
+    }
+
+    /**
+     * @return \Tobscure\JsonApi\Relationship
+     */
+    protected function hideUser($discussion)
+    {
+        return $this->hasOne($discussion, 'Flarum\Api\Serializer\UserBasicSerializer');
     }
 }
diff --git a/src/Api/Serializer/DiscussionSerializer.php b/src/Api/Serializer/DiscussionSerializer.php
@@ -64,12 +64,4 @@ protected function getDefaultAttributes($discussion)
 
         return $attributes;
     }
-
-    /**
-     * @return \Tobscure\JsonApi\Relationship
-     */
-    protected function hideUser($discussion)
-    {
-        return $this->hasOne($discussion, 'Flarum\Api\Serializer\UserSerializer');
-    }
 }
diff --git a/src/Api/Serializer/PostBasicSerializer.php b/src/Api/Serializer/PostBasicSerializer.php
@@ -12,6 +12,7 @@
 namespace Flarum\Api\Serializer;
 
 use Flarum\Core\Post;
+use Flarum\Core\Post\CommentPost;
 use InvalidArgumentException;
 
 class PostBasicSerializer extends AbstractSerializer
@@ -42,6 +43,12 @@ protected function getDefaultAttributes($post)
             'contentType' => $post->type
         ];
 
+        if ($post instanceof CommentPost) {
+            $attributes['contentHtml'] = $post->content_html;
+        } else {
+            $attributes['content'] = $post->content;
+        }
+
         return $attributes;
     }