Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the misalignment between modules imported in dev (via runInlinedModule) vs modules imported in production #108

Open
dario-piotrowicz opened this issue Dec 10, 2024 · 0 comments

Comments

@dario-piotrowicz
Copy link
Contributor

As discussed at length in #83, there is an inherit difference in workerd between modules that are actually imported and modules that are imported using eval inside runInlinedModule (which is needed for Vite's dev modules handling/abstraction).

And it doesn't seem like we can align the two1.

This misalignment is something we should ideally document somewhere so that users could, if needed, be aware of it.

Footnotes

  1. I think that we could in theory actually add some heavy handed hacks to manipulate the code to align the dev and production as closely as possible, but that would most likely be quite complex, brittle and overall not worth it, so I think we should really not consider it unless a very very strong argument is made for something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant