Dual-stack support #1448
Merged
Dual-stack support #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbuil
force-pushed
the
dualstack-cherryPick
branch
2 times, most recently
from
869d8d9 to
fcd6ba2
Compare
Closed
manuelbuil
force-pushed
the
dualstack-cherryPick
branch
from
fcd6ba2 to
5dd8eef
Compare
vadorovsky
suggested changes
Jun 14, 2021
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (dev *vxlanDevice) MACAddr() net.HardwareAddr { | ||
| return dev.link.HardwareAddr | ||
| } | ||
|
|
||
| type neighbor struct { | ||
| MAC net.HardwareAddr | ||
| IP ip.IP4 |
There was a problem hiding this comment.
Do we want to support IPv6-only installations? I would assume "yes" and in that case, I would convert this to a pointer as well.
There was a problem hiding this comment.
Still remains unanswered ;)
There was a problem hiding this comment.
Thanks for the heads up, I had forgot about this. Yes! Good idea. I must change this
There was a problem hiding this comment.
After looking a bit more into this, I think this change should be prepared in a separated PR because it requires a not small refactor. I created an issue about this => #1453
manuelbuil
force-pushed
the
dualstack-cherryPick
branch
from
5dd8eef to
78bd70c
Compare
vadorovsky
approved these changes
Jun 29, 2021
Add new option for flannel daemon to support dual stack:
- "publicIPv6": "IPv6 accessible by other nodes for
inter-host communication"
- "auto-detect-ipv4": "auto detect ipv4 address of the iface",
default value is true.
- "auto-detect-ipv6": "auto detect ipv6 address of the iface",
default value is false
Add new option into `net-conf.json` configuration, like following:
{
"EnableIPv4": true,
"EnableIPv6": true,
"Network": "172.16.0.0/16",
"IPv6Network": "fc00::/48",
"Backend": {
"Type": "vxlan"
}
}
EnableIPv4 default value is true for useing kube subnet manager.
EnableIpv6 default value is false.
Flannel dual stack feature has limitation, only work with vxlan backend
and kube subnet manager now. To enable flannel dual stack feature, need
to do the following step:
1. setting flanneld daemon with "--kube-subnet-mgr --auto-detect-ipv6"
2. settting "EnableIPv6" and "IPv6Network" in "net-conf.json" like the
above configuration.
3. setting network interface that flannel used ipv6 address and
default ipv6 gateway in the host node.
4. vxlan support ipv6 tunnel require kernel version >= 3.12.
Signed-off-by: yaoice <[email protected]>
manuelbuil
force-pushed
the
dualstack-cherryPick
branch
2 times, most recently
from
5ab3214 to
ba9a55d
Compare
This patch addresses the reviews made on the original PR Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
force-pushed
the
dualstack-cherryPick
branch
from
ba9a55d to
d23baf4
Compare
|
Should this have closed #248? |
Not exactly. Because flannel does not support ipv6 only yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new option for flannel daemon to support dual stack:
inter-host communication"
Add new option into
net-conf.jsonconfiguration, like following:{
"EnableIPv4": true,
"EnableIPv6": true,
"Network": "172.16.0.0/16",
"IPv6Network": "fc00::/48",
"Backend": {
"Type": "vxlan"
}
}
EnableIPv4 default value is true for using kube subnet manager.
EnableIpv6 default value is false.
Flannel dual stack feature has limitation, only work with vxlan backend
and kube subnet manager now. To enable flannel dual stack feature, need
to do the following step:
above configuration.
default ipv6 gateway in the host node.
Failed to ensure iptables rules: Error tearing down rules: running [/sbin/ip6tables -t nat -D POSTROUTING -s fc00::/48 ! -d ff00::/8 -j MASQUERADE --random-fully --wait]: exit status 2: ip6tables v1.8.4 (legacy): unknown option "--random-fully"==> Upgrade Alpine version #1447Signed-off-by: yaoice [email protected]
Description
Todos
Release Note
It also need flannel cni plugin to support dual stack ip allocation, so it
depends on: containernetworking/plugins#570
#248