Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please allow free hand rotation of pinned capture #1915

Open
elad2109 opened this issue Sep 21, 2021 · 17 comments
Open

Please allow free hand rotation of pinned capture #1915

elad2109 opened this issue Sep 21, 2021 · 17 comments
Labels
Enhancement Feature requests and code enhancements

Comments

@elad2109
Copy link

Would really appreciate it.

@mmahmoudian
Copy link
Member

Isn't this a duplicate of #954 (comment) ?

@mmahmoudian mmahmoudian added the Waiting For Info Addressing the issue or merging the PR is halted and we are waiting for more info to be provided. label Sep 22, 2021
@elad2109
Copy link
Author

Yes, but being a comment- will it be noticed?

@mmahmoudian
Copy link
Member

That thread is about overhauling the pin tool behaviour, so there is a high chance it gets noticed, but no guarantees. I'll keep you suggestion to make sure it'll be noticed.

But one personal question: what is the use case of such feature?

@mmahmoudian mmahmoudian added Enhancement Feature requests and code enhancements and removed Waiting For Info Addressing the issue or merging the PR is halted and we are waiting for more info to be provided. labels Sep 27, 2021
@panpuchkov
Copy link
Contributor

It's not an every day task, as for me.
If you really want sometimes to have some complicated editing you have a big number of specialized software like Photoshop, Gimp etc.
Flameshot should stay lightweight and do not consume too much resources.

@elad2109
Copy link
Author

what is the use case of such feature?

So many.
My dad sends an image upside down and I want to help him rotate it.
Me, taking pin captures of images and want to send them tilted.
Even just fun putting one pinned capture over another (interior design sketch).

Yes, it can all be done in photoshop. But then also adding text, adding arrows, adding number tags.

We can ask the same thing about pinned captures. Why do we use it?
For me it's a killer feature. Saves me clicks and time opening other editing apps.

@panpuchkov
Copy link
Contributor

@elad2109
I don't think that the majority need it. You described very specific cases.

  • "Rotate photo"? You'll lose image quality, it's better to save the original image and rotate it. Number of viewers (not even editors) allow to rotate and save image.
  • "Make and interior design"? The next feature request will be scaling, shadowing, transparency etc.
    There're a lot of other good software for these purposes.

If it is really your every day nee you can just run Gimp on "PrintScreen" key and save to folder which will be connected to DropBox or GoogleDrive.

I don’t think you’ll buy a bus to drive to work every day just because you can invite a lot of friends for a picnic one day. And that is true for most of us.

Most of us love Flameshot for its lightness and speed.

@elad2109
Copy link
Author

Thanks, I just replied to @mmahmoudian question.

By the same token, why do we have "pinned capture"? Is it part of a car or a bus when commuting?

@mmahmoudian
Copy link
Member

@elad2109 I believe what @ThePurple meant by the bus analogy was that the bus is a one time niche use case and it would be extra bloat to have extra code shipped to everyone when it has such a unique and niche utility.

Rotating the pinned image would most probably dramatically hurt the quality as all the pixels are squares and when you rotate you should spread that colour across multiple pixels which will cause distortion. That's why in tools like gimp and photoshop when you rotate the quality is good but when you press enter to apply the rotation, the image gets bad.

I would also agree with @ThePurple that there tends to be a snowball effect with such features and we should be vigilant and know where is the optimal place to draw the line.

All these said, I personally don't have a strong feeling fore or against this feature. I still prefer to hear more from the community.

@borgmanJeremy
Copy link
Contributor

borgmanJeremy commented Sep 30, 2021

I dont have a strong preference. I will note that this is not going to be as trivial as it sounds with the new "off screen" feature I am working on.

Edit: I'll also add I had a use for this today

@elad2109
Copy link
Author

Edit: I'll also add I had a use for this today

Interesting. In what case?

I appreciate it. I know it's not a must. I thought it was worth requesting.

TIA

@borgmanJeremy
Copy link
Contributor

Interesting. In what case?

I screenshotted and pinned a picture from a pdf, and in the pdf the image was upside down, it would have been handy to rotate it.

@exynil
Copy link

exynil commented Jan 23, 2023

I agree with the issue author. We need this feature.

@mmahmoudian
Copy link
Member

@exynil at the moment we have 90 degrees rotation which was provided via #2737. These exist in the right-click menu

image

@exynil
Copy link

exynil commented Jan 23, 2023

@mmahmoudian thanks for the quick response.

Does it only work on iOS or all platforms? I looked at all the settings and did not find where it would be possible to turn it on. My menu looks like this.

OS: ArchLinux
Version: 12.1.0-1
1
2
3

@mmahmoudian
Copy link
Member

@elad2109

Does it only work on iOS or all platforms?

We do not support iOS nor Android. But considering the desktop background in your screenshot, you probably meant to say "macOS" (although your Flameshot About window says "Linux"). In that case, it works on every platform we support (i.e Linux, macOS, Windows), and also most probably BSD.

My menu looks like this

As you can see, the #2737 is merged on Jul 10, 2022, but the V12.1.0 was released on Jul 3, 2022. You can also see that it it scheduled for v13 release. Therefore you have to install development version:

  • if you are Arch based Linux, use AUR
  • if you want to compile it yourself, download the source code
  • if you want to install a pre-compiled, get it from our Development Build page

When you install development version, your Flameshot would not be 12.1.0-1 (-) but instead would be something like:
image

@exynil
Copy link

exynil commented Jan 23, 2023

@mmahmoudian Thank you!

@jspatz
Copy link

jspatz commented Jun 6, 2023

I have another use case for rotation of captured images within Flameshot: OCR. I have a custom hotkey mapped to bash -c 'leafpad <(flameshot gui -r | tesseract - -)' . This pipes the selected image into my OCR tool and then opens it in a simple text editor for easy copying/pasting. I use this regularly to capture snippets of text from scanned images or screenshots sent to me by other people.

However, especially in the case of scanned documents, text in images can be misaligned, and OCR software has a hard time recognizing text that isn't upright. My current workflow in this situation is to first capture the image, open it in GIMP, rotate it, then run the above OCR pipeline. The ability to rotate at the point of capture would be extremely convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and code enhancements
Projects
None yet
Development

No branches or pull requests

6 participants