Elements in 'do_not_skip' must be one of "pull_request", "push", "workflow_dispatch", "schedule", "release"

[benshabatnoam]

Hi,
We're getting this error the first time today and we never changed our yml file.
Could this be because of this PR (#273) that was merged 3 hours ago?

[benshabatnoam]

OK, I can confirm 100% sure that this is a v5 error. I just re-run the same commit using v4 and it works...

[paescuj]

So what does your do_not_skip input look like?

[benshabatnoam]

do_not_skip: '["functions/**", "push", "workflow_dispatch", "schedule"]'
I guess that's (functions/**) not support with v5 anymore?

[paescuj]

Hmm, where does functions/** come from? As far as I know this is not a valid trigger, see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows.

[benshabatnoam]

I see. So if I got it right, you're saying that the do_not_skip key is meant for triggered event?
If so, how can we achieve our original goal to 'do_no_skip' the process once there are changes to the functions folder?

[paescuj]

I see. So if I got it right, you're saying that the do_not_skip key is meant for triggered event?

Exactly! See also the documentation for the do_not_skip input.

If so, how can we achieve our original goal to 'do_no_skip' the process once there are changes to the functions folder?

That depends on your exact goal:

• If you want to run the workflow only if there are some changes in the functions folder, you can use the paths input:

  paths: '["functions/**"]'

  With this option the workflow will be skipped if there are changes to other files but ones in the functions folder or if the exact same files have already been successfully checked in an older run (see https://github.com/fkirc/skip-duplicate-actions#option-3-look-for-successful-checks-of-previous-commits).

• If you want to run the workflow if there are any changes (including files in the functions folder) you don't need to set any special option because this is already the default behavior of skip-duplicate-actions.

• If you want to never skip the workflow if there are some changes in the functions folder, regardless if the exact same files have already been successfully checked in an older run, you could probably (not tested!) use something like this:

  pre_job:
    runs-on: ubuntu-latest
    outputs:
      should_skip: ${{ steps.skip_check.outputs.should_skip }}
      paths_result: ${{ steps.skip_check.outputs.paths_result }}
    steps:
      - id: skip_check
        uses: fkirc/skip-duplicate-actions@v5
        with:
          skip_after_successful_duplicate: 'false' # Important!
          paths_filter: |
            functions:
              paths:
                - 'functions/**'
  
  example_job:
    needs: pre_job
    if: '!fromJSON(needs.pre_job.outputs.paths_result).global.should_skip || !fromJSON(needs.pre_job.outputs.paths_result).functions.should_skip'
    # ...

[paescuj]

Closing this as I assume the problem could be solved.

[benshabatnoam]

@paescuj thanks for the awesome support.

[paescuj]

You're very welcome! 😃