From 520cf2ee43f203b85bb7e0d580988d71d1a2531b Mon Sep 17 00:00:00 2001 From: Ievgen Sorokopud Date: Wed, 7 Feb 2024 11:30:59 +0100 Subject: [PATCH] Fix flaky tests (#175965) ## Summary These changes fix flaky alert assignments cypress tests: - https://github.com/elastic/kibana/issues/173429 - https://github.com/elastic/kibana/issues/172520 - https://github.com/elastic/kibana/issues/172557 @MadameSheema mentioned that there were a lot of changes around login functionality recently which could have fixed original issues. We agreed that we will run a flaky test runner and if everything works fine we would un-skip tests and monitor them after the merge. ### Checklist Delete any items that are not applicable to this PR. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ESS 97 times](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5064) - [Serverless 97 times](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5052) --- .../detection_alerts/assignments/assignments.cy.ts | 3 +-- .../assignments/assignments_serverless_complete.cy.ts | 3 +-- .../assignments/assignments_serverless_essentials.cy.ts | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments.cy.ts index 5dbf14796c583..21a67b7fb4ea4 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments.cy.ts @@ -42,8 +42,7 @@ import { } from '../../../../../tasks/alert_assignments'; import { ALERTS_COUNT } from '../../../../../screens/alerts'; -// Failing: See https://github.com/elastic/kibana/issues/173429 -describe.skip('Alert user assignment - ESS & Serverless', { tags: ['@ess', '@serverless'] }, () => { +describe('Alert user assignment - ESS & Serverless', { tags: ['@ess', '@serverless'] }, () => { before(() => { cy.task('esArchiverLoad', { archiveName: 'auditbeat_multiple' }); diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments_serverless_complete.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments_serverless_complete.cy.ts index 72afcb304f893..f026e4b2262e4 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments_serverless_complete.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments_serverless_complete.cy.ts @@ -20,8 +20,7 @@ import { loadPageAs, } from '../../../../../tasks/alert_assignments'; -// FLAKY: https://github.com/elastic/kibana/issues/172557 -describe.skip( +describe( 'Alert user assignment - Serverless Complete', { tags: ['@serverless'], diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments_serverless_essentials.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments_serverless_essentials.cy.ts index 5ae60a01a0e8b..f8bbf2620a542 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments_serverless_essentials.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments_serverless_essentials.cy.ts @@ -20,8 +20,7 @@ import { loadPageAs, } from '../../../../../tasks/alert_assignments'; -// FLAKY: https://github.com/elastic/kibana/issues/172520 -describe.skip( +describe( 'Alert user assignment - Serverless Essentials', { tags: ['@serverless'],