-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not check position/limit error when lower limit and upper limit is same #726
Conversation
Refer to this link for build results (access rights to CI server needed): |
Is this dummy joint? |
I think this is originally base 6dof of wrl file and wrongly interpreted by 2015年7月20日月曜日、Shunichi [email protected]さんは書きました:
◉ Kei Okada |
I see, thanks. |
do not check position/limit error when lower limit and upper limit is same
@@ -230,7 +230,8 @@ RTC::ReturnCode_t SoftErrorLimiter::onExecute(RTC::UniqueId ec_id) | |||
double qvel = (m_qRef.data[i] - prev_angle[i]) / dt; | |||
double lvlimit = m_robot->joint(i)->lvlimit + 0.000175; // 0.01 deg / sec | |||
double uvlimit = m_robot->joint(i)->uvlimit - 0.000175; | |||
if ( servo_state[i] == 1 && ((lvlimit > qvel) || (uvlimit < qvel)) ) { | |||
// fixed joint has ulimit = vlimit | |||
if ( servo_state[i] == 1 && (uvlimit < uvlimit) && ((lvlimit > qvel) || (uvlimit < qvel)) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちらですが、
uvlimit < uvlimit
でなくて
lvlimit < uvlimit
ですね。
現状のものだとリミットがかかってない状態になりました。
Fix bug of Velocity limitation in #726
some robot has joint which upper limit and lower limit has same value, for example
https://raw.githubusercontent.com/start-jsk/rtmros_hironx/hydro-devel/hironx_ros_bridge/models/kawada-hironx.dae
and this outputs
https://travis-ci.org/start-jsk/rtmros_common/jobs/71699630
This PR skips limit check if ulimit and ulimit are same (actually if ulimit < llimit)