Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CollisionDetector] Fix collision loop #993

Merged
merged 5 commits into from
May 20, 2016

Conversation

YoheiKakiuchi
Copy link
Contributor

#992
のテストに、
#990
のCollisionDetectorの修正を追加しています。

@k-okada
Copy link
Contributor

k-okada commented May 17, 2016

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2627/

Build Log
last 10 lines

[...truncated 58 lines...]
    at org.jenkinsci.plugins.ghprb.GhprbRepository.createCommitStatus(GhprbRepository.java:122)
    at org.jenkinsci.plugins.ghprb.GhprbBuilds.onCompleted(GhprbBuilds.java:118)
    at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:27)
    at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:12)
    at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:202)
    at hudson.model.Run.execute(Run.java:1786)
    at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
    at hudson.model.ResourceController.execute(ResourceController.java:98)
    at hudson.model.Executor.run(Executor.java:410)

Test FAILed.

@YoheiKakiuchi
Copy link
Contributor Author

test11とtest14で失敗していますが、test14は確率的に失敗しているようなので問題ないかと思います。
test11はバージョンチェック入れていないのですが、失敗してはいけない気がしています、手元では失敗しません。

test11

[ROSTEST]-----------------------------------------------------------------------

[hrpsys.rosunit-samplerobot_co_loop/test_demo][FAILURE]-------------------------
File "/usr/lib/python2.7/unittest/case.py", line 327, in run
    testMethod()
  File "/home/travis/hrpsys_ws/install_isolated/share/hrpsys/test/test-samplerobot-collision.py", line 15, in test_demo
    samplerobot_collision_detector.demo_co_loop()
  File "/home/travis/hrpsys_ws/install_isolated/share/hrpsys/samples/SampleRobot/samplerobot_collision_detector.py", line 139, in demo_co_loop
    demoCollisionCheckFail()
  File "/home/travis/hrpsys_ws/install_isolated/share/hrpsys/samples/SampleRobot/samplerobot_collision_detector.py", line 44, in demoCollisionCheckFail
    assert((not cs.safe_posture) is True)
--------------------------------------------------------------------------------


SUMMARY
�[1;31m * RESULT: FAIL�[0m
 * TESTS: 1
 * ERRORS: 0
�[1;31m * FAILURES: 1�[0m

test14

======================================================================
FAIL: test_hz (__main__.HzTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/ros/hydro/share/rostest/nodes/hztest/hztest", line 115, in test_hz
    self._test_hz(hz, hzerror, topic, test_duration, wait_time)
  File "/opt/ros/hydro/share/rostest/nodes/hztest/hztest", line 185, in _test_hz
    (rate, self.min_rate))
AssertionError: average rate (192.169Hz) exceeded minimum (300.000Hz)

----------------------------------------------------------------------
Ran 1 test in 5.391s

FAILED (failures=1)
-------------------------------------------------------------
SUMMARY:
 * RESULT: FAIL
 * TESTS: 1
 * ERRORS: 0 []
 * FAILURES: 1 [test_hz]

@k-okada
Copy link
Contributor

k-okada commented May 18, 2016

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2628/

Build Log
last 10 lines

[...truncated 58 lines...]
    at org.jenkinsci.plugins.ghprb.GhprbRepository.createCommitStatus(GhprbRepository.java:122)
    at org.jenkinsci.plugins.ghprb.GhprbBuilds.onCompleted(GhprbBuilds.java:118)
    at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:27)
    at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:12)
    at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:202)
    at hudson.model.Run.execute(Run.java:1786)
    at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
    at hudson.model.ResourceController.execute(ResourceController.java:98)
    at hudson.model.Executor.run(Executor.java:410)

Test FAILed.

@k-okada
Copy link
Contributor

k-okada commented May 20, 2016

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2629/

Build Log
last 10 lines

[...truncated 58 lines...]
    at org.jenkinsci.plugins.ghprb.GhprbRepository.createCommitStatus(GhprbRepository.java:122)
    at org.jenkinsci.plugins.ghprb.GhprbBuilds.onCompleted(GhprbBuilds.java:118)
    at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:27)
    at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:12)
    at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:202)
    at hudson.model.Run.execute(Run.java:1786)
    at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
    at hudson.model.ResourceController.execute(ResourceController.java:98)
    at hudson.model.Executor.run(Executor.java:410)

Test FAILed.

@k-okada
Copy link
Contributor

k-okada commented May 20, 2016

全部一気にリスタートして通ることはないとおもうので,
https://github.com/jsk-ros-pkg/jsk_common
のrestart from slack あたりを見て個別にリスタートしたほうがよさそうです.

◉ Kei Okada

On Fri, May 20, 2016 at 3:58 PM, Yohei Kakiuchi [email protected]
wrote:

Reopened #993 #993.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#993 (comment)

@YoheiKakiuchi
Copy link
Contributor Author

ありがとうございます。
travis 通りました。

@fkanehiro fkanehiro merged commit 3cabebb into fkanehiro:master May 20, 2016
@YoheiKakiuchi YoheiKakiuchi mentioned this pull request May 20, 2016
@YoheiKakiuchi YoheiKakiuchi deleted the fix_collision_loop2 branch May 24, 2016 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants