Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix checkArrayBetween function #919

Merged
merged 1 commit into from
Dec 19, 2015

Conversation

mmurooka
Copy link
Contributor

@snozawa さん
https://github.com/fkanehiro/hrpsys-base/blob/master/sample/SampleRobot/samplerobot_sequence_player.py#L61-L62checkArrayBetween
arr1とarr3の間にarr2が入っているかを確認する関数だと思うのですが,
このPRの変更後の方が正しいように思うのですがご確認いただけますでしょうか.

@k-okada
Copy link
Contributor

k-okada commented Dec 19, 2015

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2492/
Test PASSed.

@snozawa
Copy link
Contributor

snozawa commented Dec 19, 2015

そうですね。
ここ先日みていてあれおかしいと思ってました。
107b172
をみると@k-okadaさん作のようなのですが、こちらでも確認してみます。

@snozawa
Copy link
Contributor

snozawa commented Dec 19, 2015

PRみてみましたが、よさそうでした。
travis も通ってるようです。

fkanehiro added a commit that referenced this pull request Dec 19, 2015
@fkanehiro fkanehiro merged commit f2fdc0e into fkanehiro:master Dec 19, 2015
@mmurooka
Copy link
Contributor Author

ありがとうございます.
@core-dump さん,協力ありがとうございました.

@mmurooka mmurooka deleted the fix-check-between branch December 19, 2015 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants