Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect use-after-free of hrpExecutionContext #1208

Merged
merged 2 commits into from
Oct 13, 2017

Conversation

jun0
Copy link
Contributor

@jun0 jun0 commented Oct 12, 2017

These changes will hopefully track down why hrpExecutionContext is being freed prematurely.

@fkanehiro
Copy link
Owner

travisでのビルドが通らないようです。
travisの環境が古いことが原因だとは思うのですが、古い環境にも対応することは可能でしょうか。

@k-okada
Copy link
Contributor

k-okada commented Oct 13, 2017

[ 22%] Building CXX object ec/hrpEC/CMakeFiles/hrpEC.dir/hrpEC.o
In file included from /home/travis/build/fkanehiro/hrpsys-base/ec/hrpEC/hrpEC.cpp:3:0:
/home/travis/build/fkanehiro/hrpsys-base/ec/hrpEC/hrpEC.h:38:20: error: expected ';' at end of member declaration
/home/travis/build/fkanehiro/hrpsys-base/ec/hrpEC/hrpEC.h:38:22: error: 'override' does not name a type

@jun0
Copy link
Contributor Author

jun0 commented Oct 13, 2017

C++98 でもビルドできるように修正しました。

@fkanehiro fkanehiro merged commit 6573846 into fkanehiro:master Oct 13, 2017
@snozawa
Copy link
Contributor

snozawa commented Oct 16, 2017

hrpEC-art.cppでのm_thread_pendingメンバ変数の初期化も追加する必要はないでしょうか。

@jun0
Copy link
Contributor Author

jun0 commented Oct 16, 2017

あります! ご指摘ありがとうございます。

@snozawa
Copy link
Contributor

snozawa commented Oct 17, 2017

ご対応いただきありがとうございます。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants