Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py][doc] Clarify setTargetPoseRelative's wait behavior (addresses #1121). #1135

Merged
merged 1 commit into from
May 25, 2017

Conversation

130s
Copy link
Contributor

@130s 130s commented May 15, 2017

wait argument is to regulate the commands previously run before setTargetPoseRelative, but there are users who thought it stops subsequent commands.

This change hopefully clarifies the difference.

…anehiro#1121).

`wait` argument is to regulate the commands previously run before `setTargetPoseRelative`, but there are users who thought it stops subsequent commands.
This change hopefully clarifies the difference.
@130s 130s closed this May 16, 2017
@130s 130s reopened this May 16, 2017
@130s
Copy link
Contributor Author

130s commented May 19, 2017

Doc のみの変更な割に Travis がいつも同じ job で失敗しています.ログ見る限りやはりこの PR 変更箇所が関係しているわけでもなさそうに見えます.

下流 Hironx のテストなので,治すべきなら治そうかと思いましたが,ROS の Hydro のバイナリなので無理でした.
ということで何度か restart して通るのを待つしかないのでしょうか...?

terminate called after throwing an instance of 'CORBA::COMM_FAILURE'
state_publisher: /usr/include/boost/thread/pthread/pthread_mutex_scoped_lock.hpp:26: boost::pthread::pthread_mutex_scoped_lock::pthread_mutex_scoped_lock(pthread_mutex_t*): Assertion `!pthread_mutex_lock(m)' failed.
Traceback (most recent call last):
  File "/opt/ros/hydro/share/hironx_ros_bridge/test/test_hironx_ros_bridge_send.py", line 93, in <module>
    rostest.rosrun(PKG, 'test_hronx_ros_bridge_send', TestHiroROSBridgeSend)
  File "/opt/ros/hydro/lib/python2.7/dist-packages/rostest/__init__.py", line 140, in rosrun
    result = rosunit.create_xml_runner(package, test_name, result_file).run(suite)
  File "/opt/ros/hydro/lib/python2.7/dist-packages/rosunit/xmlrunner.py", line 233, in run
    test(result)
  File "/usr/lib/python2.7/unittest/suite.py", line 70, in __call__
    return self.run(*args, **kwds)
  File "/usr/lib/python2.7/unittest/suite.py", line 108, in run
    test(result)
  File "/usr/lib/python2.7/unittest/case.py", line 391, in __call__
    return self.run(*args, **kwds)
  File "/usr/lib/python2.7/unittest/case.py", line 327, in run
    testMethod()
  File "/opt/ros/hydro/share/hironx_ros_bridge/test/test_hironx_ros_bridge_send.py", line 69, in test_send_goal_and_clear
    rospy.sleep(1.0)
  File "/opt/ros/hydro/lib/python2.7/dist-packages/rospy/timer.py", line 133, in sleep
    raise rospy.exceptions.ROSInterruptException("ROS shutdown request")
rospy.exceptions.ROSInterruptException: ROS shutdown request

@130s 130s closed this May 19, 2017
@130s 130s reopened this May 19, 2017
@k-okada
Copy link
Contributor

k-okada commented May 22, 2017 via email

@130s
Copy link
Contributor Author

130s commented May 23, 2017

と言っていたら Travis に伝わったか,全部テスト通りました.Review ねがいます.

@k-okada
Copy link
Contributor

k-okada commented May 25, 2017

LGTM

@fkanehiro fkanehiro merged commit 46e3265 into fkanehiro:master May 25, 2017
@130s 130s deleted the py/doc branch May 26, 2017 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants