-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py][doc] Clarify setTargetPoseRelative's wait behavior (addresses #1121). #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anehiro#1121). `wait` argument is to regulate the commands previously run before `setTargetPoseRelative`, but there are users who thought it stops subsequent commands. This change hopefully clarifies the difference.
Doc のみの変更な割に Travis がいつも同じ job で失敗しています.ログ見る限りやはりこの PR 変更箇所が関係しているわけでもなさそうに見えます. 下流 Hironx のテストなので,治すべきなら治そうかと思いましたが,ROS の Hydro のバイナリなので無理でした.
|
そうですね.通りにくいテストの部分はindigoでは解決されているでしょうか.であれば、
https://github.com/fkanehiro/hrpsys-base/blob/master/.travis.sh#L369
みたいに、テストを更新するのはあるとはおもいます.
…--
◉ Kei Okada
2017-05-20 7:56 GMT+09:00 Isaac I.Y. Saito <[email protected]>:
Doc のみの変更な割に Travis がいつも同じ job で失敗しています.ログ見る限りやはりこの PR
変更箇所が関係しているわけでもなさそうに見えます.
下流 Hironx のテストなので,治すべきなら治そうかと思いましたが,ROS の Hydro のバイナリなので無理でした.
ということで何度か restart して通るのを待つしかないのでしょうか...?
- TEST_TYPE=work_with_downstream TEST_PACKAGE=hironx-ros-bridge
USE_SRC_OPENHRP3=true
<https://github.com/fkanehiro/hrpsys-base/blob/c7d313eae93c6eca2c31c965d1018165a590c9b6/.travis.yml#L27>
terminate called after throwing an instance of 'CORBA::COMM_FAILURE'
state_publisher: /usr/include/boost/thread/pthread/pthread_mutex_scoped_lock.hpp:26: boost::pthread::pthread_mutex_scoped_lock::pthread_mutex_scoped_lock(pthread_mutex_t*): Assertion `!pthread_mutex_lock(m)' failed.
Traceback (most recent call last):
File "/opt/ros/hydro/share/hironx_ros_bridge/test/test_hironx_ros_bridge_send.py", line 93, in <module>
rostest.rosrun(PKG, 'test_hronx_ros_bridge_send', TestHiroROSBridgeSend)
File "/opt/ros/hydro/lib/python2.7/dist-packages/rostest/__init__.py", line 140, in rosrun
result = rosunit.create_xml_runner(package, test_name, result_file).run(suite)
File "/opt/ros/hydro/lib/python2.7/dist-packages/rosunit/xmlrunner.py", line 233, in run
test(result)
File "/usr/lib/python2.7/unittest/suite.py", line 70, in __call__
return self.run(*args, **kwds)
File "/usr/lib/python2.7/unittest/suite.py", line 108, in run
test(result)
File "/usr/lib/python2.7/unittest/case.py", line 391, in __call__
return self.run(*args, **kwds)
File "/usr/lib/python2.7/unittest/case.py", line 327, in run
testMethod()
File "/opt/ros/hydro/share/hironx_ros_bridge/test/test_hironx_ros_bridge_send.py", line 69, in test_send_goal_and_clear
rospy.sleep(1.0)
File "/opt/ros/hydro/lib/python2.7/dist-packages/rospy/timer.py", line 133, in sleep
raise rospy.exceptions.ROSInterruptException("ROS shutdown request")
rospy.exceptions.ROSInterruptException: ROS shutdown request
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1135 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3OfvmUOpBv-EIiDZDqq7XI9akHnyks5r7h4ogaJpZM4NbmWM>
.
|
と言っていたら Travis に伝わったか,全部テスト通りました.Review ねがいます. |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait
argument is to regulate the commands previously run beforesetTargetPoseRelative
, but there are users who thought it stops subsequent commands.This change hopefully clarifies the difference.