Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc][py] Elaborate methods (playPattern*, setTarget*, startImpedance) #1120

Merged
merged 5 commits into from
May 10, 2017

Conversation

130s
Copy link
Contributor

@130s 130s commented Mar 24, 2017

No description provided.

@k-okada
Copy link
Contributor

k-okada commented Mar 24, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2829/
Test PASSed.

@k-okada
Copy link
Contributor

k-okada commented Mar 24, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2830/
Test PASSed.

@k-okada
Copy link
Contributor

k-okada commented Mar 27, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2831/
Test PASSed.

@130s 130s changed the title [doc][py] Elaborate playPattern* methods. [doc][py] Elaborate playPattern* and setTarget* methods. Mar 29, 2017
@k-okada
Copy link
Contributor

k-okada commented Mar 29, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2832/
Test PASSed.

@k-okada
Copy link
Contributor

k-okada commented Mar 30, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2833/
Test PASSed.

@k-okada
Copy link
Contributor

k-okada commented Apr 4, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2834/
Test PASSed.

@130s
Copy link
Contributor Author

130s commented Apr 4, 2017

Re-triggering travis

@130s 130s closed this Apr 4, 2017
@130s 130s reopened this Apr 4, 2017
@130s 130s changed the title [doc][py] Elaborate playPattern* and setTarget* methods. [doc][py] Elaborate methods (playPattern*, setTarget*, startImpedance) May 3, 2017
@k-okada
Copy link
Contributor

k-okada commented May 4, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2850/
Test PASSed.

@k-okada
Copy link
Contributor

k-okada commented May 4, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2851/
Test PASSed.

@k-okada
Copy link
Contributor

k-okada commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2856/
Test PASSed.

@k-okada
Copy link
Contributor

k-okada commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2857/
Test PASSed.

130s added a commit to 130s/rtmros_hironx that referenced this pull request May 9, 2017
The added change is a duplicate with the PR in the upstream fkanehiro/hrpsys-base#1120, which assumedly will take awhile to get merged. Once it does then this commit should be reverted to avoid duplicate maintenance effort.
130s added a commit to 130s/rtmros_hironx that referenced this pull request May 9, 2017
The added change is a duplicate of a commit in the PR in the upstream fkanehiro/hrpsys-base#1120, which assumedly will take awhile to get merged. Once it does then this commit should be reverted to avoid duplicate maintenance effort.
@k-okada
Copy link
Contributor

k-okada commented May 10, 2017 via email

130s added 2 commits May 10, 2017 11:53
AFAI understood from looking at [SequencePlayer/SequencePlayer.cpp](https://github.com/fkanehiro/hrpsys-base/blob/350a3bcdeafd39d82a44c2dbde6a279adb6d88eb/rtc/SequencePlayer/SequencePlayer.cpp#L547)'s implementation, time taken for planning and other processes are not considered for "`tm`" argument.
130s added 3 commits May 10, 2017 11:53
Similar info should be added to IDL level (this Python file is only the end-user API so the number of audience can be minimum).
@130s
Copy link
Contributor Author

130s commented May 10, 2017

  • This only includes the time taken for execution + (i.e. time for planning and other misc. processes are considered).

まず,大事な間違いをしていたので commit を更新しました.

  • x i.e. time for planning and other misc. processes are considered).
  • o i.e. time for planning and other misc. processes are not considered).

この説明が特に必要だった状況が思い出せてませんが,はっきりさせたかった,くらいではないかと思います.

Commit msg 3725375 を見ると一応 SequencePlayer のコード上 tm は planning には係らず execution のみに係るようなのは確認したようですが,そもなぜ必要と思ったのかは書いてないですね.まあ初心者ユーザにとっては,一つのコマンド内で planning と execution が実行されているということはあまり分からないので,使ってるうちに気になった時のため等に文書化しておくのは悪くないかと.

@k-okada
Copy link
Contributor

k-okada commented May 10, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2860/
Test PASSed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants