Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test code to check ST transition problem. #1104

Merged
merged 2 commits into from
Mar 7, 2017

Conversation

snozawa
Copy link
Contributor

@snozawa snozawa commented Mar 7, 2017

Add test code to check ST transition problem.
#1098, #1102

まずはテストコードでtravisがfailするのを確認します。

@k-okada
Copy link
Contributor

k-okada commented Mar 7, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2786/

Build Log
last 10 lines

[...truncated 333.55 KB...]
   at org.jenkinsci.plugins.ghprb.GhprbRepository.createCommitStatus(GhprbRepository.java:122)
   at org.jenkinsci.plugins.ghprb.GhprbBuilds.onCompleted(GhprbBuilds.java:118)
   at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:27)
   at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:12)
   at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:211)
   at hudson.model.Run.execute(Run.java:1773)
   at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
   at hudson.model.ResourceController.execute(ResourceController.java:98)
   at hudson.model.Executor.run(Executor.java:405)

Test FAILed.

@snozawa
Copy link
Contributor Author

snozawa commented Mar 7, 2017

testコードでは、#1102
の際限コードを参考にして

  • (STがはいってて)the groundに遷移したとき : MODE_STに遷移
  • (STがはいってて)in the airに遷移したとき : MODE_AIRに遷移
  • in the air直後にstopStabilizerしたとき : MODE_IDLEに遷移
  • on the ground直後にstartStabilizerしたとき : MODE_STに遷移

など、意図した遷移になってるか確認をしています。
本当は、stopStabilizerなどを別スレッドからよんだり、上記の順序を逆にするのも
テストがいりそうですが、いずれにしても別スレッドをたてる必要がありそうで一旦これで修正にします。

@k-okada
Copy link
Contributor

k-okada commented Mar 7, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2787/
Test PASSed.

@snozawa
Copy link
Contributor Author

snozawa commented Mar 7, 2017

https://api.travis-ci.org/jobs/208478277/log.txt?deansi=true
で、修正なしの場合にtestがエラることを確認しました。
あとはじかんを待って、修正後にtravisが通るのを確認します

@snozawa snozawa mentioned this pull request Mar 7, 2017
@k-okada
Copy link
Contributor

k-okada commented Mar 7, 2017

@YoheiKakiuchi どうでしょう.よさそうでしょうか.

@snozawa
Copy link
Contributor Author

snozawa commented Mar 7, 2017

testは無事通りそうです

@YoheiKakiuchi
Copy link
Contributor

目的は達成しています。
Thanks @snozawa

@snozawa
Copy link
Contributor Author

snozawa commented Mar 7, 2017

@YoheiKakiuchi さん
ありがとうございます。

@fkanehiro
testがとおり確認が終わりましたので、お手すきのときで構いませんのでmergeをお願いできると助かります。

@fkanehiro fkanehiro merged commit b8031f3 into fkanehiro:master Mar 7, 2017
@snozawa
Copy link
Contributor Author

snozawa commented Mar 7, 2017

ありがとうございます。

@snozawa snozawa deleted the fix_st_transition branch March 7, 2017 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants