Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hrpsys_config.py] Add clearJointAngles* methods. #1064

Merged
merged 1 commit into from
Oct 30, 2016
Merged

[hrpsys_config.py] Add clearJointAngles* methods. #1064

merged 1 commit into from
Oct 30, 2016

Conversation

130s
Copy link
Contributor

@130s 130s commented Oct 30, 2016

#665 の python wrapper です．

@k-okada
Copy link
Contributor

k-okada commented Oct 30, 2016

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2729/
Test PASSed.

@k-okada
Copy link
Contributor

k-okada commented Oct 30, 2016

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2730/
Test PASSed.

@fkanehiro fkanehiro merged commit 42df157 into fkanehiro:master Oct 30, 2016
@130s 130s deleted the py/add_cancel_method branch October 30, 2016 22:49
@k-okada
Copy link
Contributor

k-okada commented Oct 31, 2016 •
edited
Loading

バージョンのチェックを入れたほうがいいともいます．315.5.0?以上でないと使えないですよね．そうでないとエラーになるはず．
ということで、このPRが通るのはテストコードが入っていないからなので、まずはテストコードいれて、ちゃんとそこで落ちるのを確認して、
そして、バージョンチェックで直ぐにReturnするようにするのがいいと思います．

@130s 130s mentioned this pull request Nov 16, 2016
Closed
k-okada
k-okada reviewed May 24, 2017
View reviewed changes
python/hrpsys_config.py
@param gname: Name of the joint group.
@return bool
'''
return self.seq_svc.clearJointAngles(gname)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  •    return self.seq_svc.clearJointAnglesOfGroup(gname)  ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the headsup, fixed in #1146

@130s 130s mentioned this pull request May 27, 2017
Open
@130s
Copy link
Contributor Author

130s commented May 27, 2017

バージョンのチェックを入れたほうがいいともいます．315.5.0?以上でないと使えないですよね．そうでないとエラーになるはず．
ということで、このPRが通るのはテストコードが入っていないからなので、まずはテストコードいれて、ちゃんとそこで落ちるのを確認して、
そして、バージョンチェックで直ぐにReturnするようにするのがいいと思います．

#1146 で対応中です．

@130s 130s mentioned this pull request May 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-okada k-okada k-okada left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@130s @k-okada @fkanehiro