Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Columns missing in Invoice #50

Closed
3 of 4 tasks
lijol opened this issue Oct 5, 2022 · 4 comments
Closed
3 of 4 tasks

Columns missing in Invoice #50

lijol opened this issue Oct 5, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@lijol
Copy link
Contributor

lijol commented Oct 5, 2022

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Missing columns

  1. PERIOD_START
  2. PERIOD_END

Describe alternatives you've considered

NA

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

Can this be expedited ? This model will not be useful to me as they are important columns
@lijol lijol added the enhancement New feature or request label Oct 5, 2022
@fivetran-joemarkiewicz
Copy link
Contributor

@lijol thanks for opening this issue! I noticed you are open to creating a PR to incorporate these new fields. If you would like to open a PR to incorporate these fields we would be happy to review and consider folding into the package!

@lijol
Copy link
Contributor Author

lijol commented Oct 11, 2022

@fivetran-joemarkiewicz i will raise the PR this week

@lijol lijol mentioned this issue Oct 12, 2022
Merged
14 tasks
@lijol
Copy link
Contributor Author

lijol commented Oct 12, 2022

raised PR #51

@lijol
Copy link
Contributor Author

lijol commented Oct 17, 2022

Added to invoice now

@lijol lijol closed this as completed Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fivetran-joemarkiewicz @lijol