Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE - [Identifiers for multiple stripe connections] #33

Closed
2 of 3 tasks
ramiz-bozai-cerebral opened this issue Jan 6, 2022 · 4 comments
Closed
2 of 3 tasks
Labels
enhancement New feature or request

Comments

@ramiz-bozai-cerebral
Copy link

ramiz-bozai-cerebral commented Jan 6, 2022

Are you a Fivetran customer?
Yes. Ramiz Bozai, Senior Data Analyst at Cerebral

Is your feature request related to a problem? Please describe.
It would be great to have an identifier denoting which data/records came from which source as I union together our different stripe tables from different connections.

Describe the solution you'd like
Having a column indicating what the source of the data is (like country) would allow us to filter that data based on the column.

Describe alternatives you've considered
This is more of a nice to have, but I understand I can possible fork this package and potentially try to add this myself.

Additional context
N/A

Please indicate the level of urgency and business impact of this request
Not urgent. Just a nice to have feature.

Are you interested in contributing to this package?

  • Yes, I can do this and open a PR for your review.
  • Possibly, but I'm not quite sure how to do this. I'd be happy to do a live coding session with someone to get this work implemented.
  • No, I'd prefer if someone else did this. I don't have the time and/or don't know how to incorporate the changes necessary.
@ramiz-bozai-cerebral ramiz-bozai-cerebral added the enhancement New feature or request label Jan 6, 2022
@fivetran-joemarkiewicz
Copy link
Contributor

Thanks for opening this feature @ramiz-bozai-cerebral! It also was great chatting with you today.

The request here would be an ideal candidate for our recent union functionality feature that we have implemented in a few other packages. Essentially we have created a way in other packages for users to union data from multiple sources before the packages performs the transformations. This would mean the union ability is native to the package.

Our team will add this to our feature request log and plan to scope this during our quarterly planning process. However, if you would like to attempt at applying this functionality yourself and open a PR, we do have supporting PRs that you could reference in the meantime! A great place to look would be our dbt_xero_source PR and dbt_xero PR which implement this functionality. I am happy to chat through these PRs if you would like.

Thanks again for opening this, and our team will respond back once we have planned for this feature!

@dietofworms
Copy link

This would be a great feature for us at Ignition too. Keen to see it merged whenever you guys get around to it 👍

@fivetran-joemarkiewicz
Copy link
Contributor

Hi All,

I wanted to post back here and let you know that we have decided to pick this feature up in our next quarter!

@fivetran-reneeli
Copy link
Contributor

Hi @ramiz-bozai-cerebral and @dietofworms! We have added the feature to allow for multiple Stripe connectors to be unioned. For more details, we've noted it in our README. As such I will close out this issue. Let me know if you have any more questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants