feature/add-action-result #38
Merged
+139
−586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
requested changes
Oct 30, 2024
fivetran-joemarkiewicz
requested changes
Nov 1, 2024
There was a problem hiding this comment.
@fivetran-catfritz thanks for these updates! I have a few final requests before this is ready for approval thanks!
There was a problem hiding this comment.
@fivetran-joemarkiewicz I have updated and this is ready for review!
fivetran-joemarkiewicz
approved these changes
Nov 1, 2024
Co-authored-by: Joe Markiewicz <[email protected]>
fivetran-reneeli
approved these changes
Nov 26, 2024
CHANGELOG.md
Outdated
|
|
||
| ## Breaking Change | ||
| - Added the `action_result` field in the `stg_marketo__activity_send_email` model to capture email action outcomes, allowing for filtering in downstream models. | ||
| - *Note:* If you have previously added this field via the `marketo__activity_send_email_passthrough_columns` variable, remove or alias it there to prevent duplicate column errors. |
There was a problem hiding this comment.
Maybe add a link to the README on the steps to alias just to make it more straightforward
There was a problem hiding this comment.
Good call. Updated!
CHANGELOG.md
Outdated
|
|
||
| ## Breaking Change | ||
| - Added the `action_result` field in the `stg_marketo__activity_send_email` model to capture email action outcomes, allowing for filtering in downstream models. | ||
| - *Note:* If you have previously added this field via the `marketo__activity_send_email_passthrough_columns` variable, remove or alias it there to prevent duplicate column errors. |
There was a problem hiding this comment.
Good call. Updated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
This PR will result in the following new package version:
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
dbt run (if incremental models are present) && dbt testBefore marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
action_resultfield is added to thestg_marketo__activity_send_emailmodel.If you had to summarize this PR in an emoji, which would it be?
💃