Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error when handling non-integer values in merged_lead_id in Snowflake #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lynziz
Copy link

@lynziz lynziz commented Jul 23, 2021

Are you a current Fivetran customer?
Yes. Lynzi, VP Data Strategy & Operations, Renaissance Learning, Inc

What change(s) does this PR introduce?
The 'cast' to integer in this model errored out on the 3 values in our Marketo leads table with non-numeric values in merged_lead_id. Replaced cast with try_cast to avoid this on Snowflake.

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No -- this works in snowflake

Is this PR in response to a previously created Issue

  • Yes, Issue [link issue number here]
  • [ x] No

How did you test the PR changes?

  • CircleCi
  • Other -- I updated it in my local dbt environment and ran dbt test and dbt run successfully

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz
Copy link
Contributor

@lynziz my apologies for just seeing this PR! Thank you so much for opening the PR. I will give it a review ASAP.

@fivetran-joemarkiewicz
Copy link
Contributor

@lynziz I just tested this on my end and was not seeing the same error on the original package within snowflake. Would you be able to provide some more context to your below statement?

our Marketo leads table with non-numeric values in merged_lead_id

My understanding is these id's should not have non-numeric characters within it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants