You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, now with the advent of Quickstart we can rely on the Quickstart Data Model to handle the enable/disable components of the above variables dynamically. As such, we should create a breaking change to swap the default value for these variables to be true to ensure that these models are captured by Quickstart and other users by default.
This will require users leverage the package outside of Quickstart to ensure the variables are disabled if necessary. We will need to call this out clearly in the CHANGELOG release notes. This change will also need to be made at the source package level as well to enable the staging models by default.
How would you implement this feature?
Enable the models by default instead of disabling them. The relevant updates would look like the following:
Before
{{ config(enabled=var('marketo__enable_campaigns', False) and var('marketo__enable_programs', False)) }}
After
{{ config(enabled=var('marketo__enable_campaigns', True) and var('marketo__enable_programs', True)) }}
Describe alternatives you've considered
No response
Are you interested in contributing this feature?
Yes.
Yes, but I will need assistance.
No.
Anything else?
No response
The text was updated successfully, but these errors were encountered:
Is there an existing feature request for this?
Describe the Feature
Currently the
marketo__enable_campaigns
andmarketo__enable_programs
are disabled by default. This results in the marketo__campagins and the marketo__programs models be turned off by default.However, now with the advent of Quickstart we can rely on the Quickstart Data Model to handle the enable/disable components of the above variables dynamically. As such, we should create a breaking change to swap the default value for these variables to be
true
to ensure that these models are captured by Quickstart and other users by default.This will require users leverage the package outside of Quickstart to ensure the variables are disabled if necessary. We will need to call this out clearly in the CHANGELOG release notes. This change will also need to be made at the source package level as well to enable the staging models by default.
How would you implement this feature?
Enable the models by default instead of disabling them. The relevant updates would look like the following:
Before
After
Describe alternatives you've considered
No response
Are you interested in contributing this feature?
Anything else?
No response
The text was updated successfully, but these errors were encountered: