Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scope all tracking state to fix imported dbt runs #273

Merged
merged 3 commits into from
Feb 8, 2017
Merged

scope all tracking state to fix imported dbt runs #273

merged 3 commits into from
Feb 8, 2017

Conversation

drewbanin
Copy link
Contributor

No description provided.

cmcarthur
cmcarthur approved these changes Feb 7, 2017
View reviewed changes
Copy link
Member

@cmcarthur cmcarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now. But, long term I'd prefer to have a global context map that gets passed around everywhere with things like invocation context, profiles, project configuration, etc.

@drewbanin
Copy link
Contributor Author

@cmcarthur agreed -- this approach definitely still leaves much to be desired. Let's revisit when we have the opportunity. Till then, merging

@drewbanin drewbanin merged commit 2677f03 into development Feb 8, 2017
@drewbanin drewbanin deleted the fix/tracking-import branch February 8, 2017 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmcarthur cmcarthur cmcarthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewbanin @cmcarthur