Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --dependency arg bug in create_adapter_plugin #2508

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

scarrucciu
Copy link
Contributor

@scarrucciu scarrucciu commented Jun 1, 2020

Fix bug in create_adapter_plugin when a dependency is not passed in.

resolves #2507

Description

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

Fix bug in create_adapter_plugin when a dependency is not passed in.
@cla-bot
Copy link

cla-bot bot commented Jun 1, 2020

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @scarrucciu

@scarrucciu
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Jun 1, 2020
@cla-bot
Copy link

cla-bot bot commented Jun 1, 2020

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! I'm going to kick off the tests, though that's just a formality, and then we'll get this merged.

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'm sorry - I just noticed that the changelog wasn't updated on this PR. Can you please add an entry to CHANGELOG.md under Contributors: with your github username that links to this PR? We want to make sure to credit you in the release notes!

@scarrucciu
Copy link
Contributor Author

Oh, I'm sorry - I just noticed that the changelog wasn't updated on this PR. Can you please add an entry to CHANGELOG.md under Contributors: with your github username that links to this PR? We want to make sure to credit you in the release notes!

@beckjake can do, within the CHANGELOG.md under which version number should I add that info?

@beckjake
Copy link
Contributor

beckjake commented Jun 1, 2020

@scarrucciu Please place it at the top, under dbt 0.18.0 (Release TBD). There should be an existing contributors list there, just follow that format. You can also feel free to add this to a new ### Fixes section for this release, following the existing pattern below.

@scarrucciu scarrucciu requested a review from beckjake June 1, 2020 16:49
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks so much for contributing @scarrucciu! I've kicked off the tests, once they pass I'll merge.

@beckjake beckjake merged commit 05634e6 into dbt-labs:dev/marian-anderson Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_adpater_plugin bug with --dependency flag
2 participants