-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --dependency arg bug in create_adapter_plugin #2508
Conversation
Fix bug in create_adapter_plugin when a dependency is not passed in.
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @scarrucciu |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! I'm going to kick off the tests, though that's just a formality, and then we'll get this merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I'm sorry - I just noticed that the changelog wasn't updated on this PR. Can you please add an entry to CHANGELOG.md under Contributors:
with your github username that links to this PR? We want to make sure to credit you in the release notes!
@beckjake can do, within the CHANGELOG.md under which version number should I add that info? |
@scarrucciu Please place it at the top, under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thanks so much for contributing @scarrucciu! I've kicked off the tests, once they pass I'll merge.
Fix bug in create_adapter_plugin when a dependency is not passed in.
resolves #2507
Description
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.