Feature/ex 110 use camera and mic hook #39
Conversation
|
Bug: When I connect and stop streaming either audio or video sometimes whole room crashes |
|
When I have auto streaming on and I connect to the server, on dashboard I see two video tracks. What's the cause? If one sends both audio and video, why there is another? If they're both video-only, what happens with audio and why there are two of them? |
| </div> | ||
| </div> | ||
| <div> | ||
| Streaming |
There was a problem hiding this comment.
I'd add colons to this and "Local" and make bigger gap between the local video/audio and this. For a while I thought this is other way round and was a bit confused. This would prevent such confusion
There was a problem hiding this comment.
Fixed. Now it looks like this:
|
|
||
| return ( | ||
| <div className="flex flex-row flex-nowrap justify-center border-4"> | ||
| <canvas ref={canvasRef} width={200} height={100}/> |
There was a problem hiding this comment.
Why so narrow? 480 would work too
There was a problem hiding this comment.
Fixed. Now the canvas width matches the width of its parent container
| JellyfishContextProvider, | ||
| useCameraAndMicrophone, | ||
| useSelector | ||
| } = create<PeerMetadata, TrackMetadata>(); |
There was a problem hiding this comment.
In my tutorial I'm using create in the App component. I'm not saying it's better but I think that using both is not ideal. What's preferred option?
There was a problem hiding this comment.
I think the best option would be to extract this 'setup' to another file
I think it's a bug in Jellyfish, and I believe it's already fixed. Please check the latest commit on the 'main' branch
And I think it'a a bug in |
readme.md
Outdated
|
|
||
| Prerequisites: | ||
|
|
||
| - Running [Jellyfish](https://github.com/jellyfish-dev/jellyfish) server. | ||
| - Created room and token of peer in that room. | ||
| You u can use [dashboard](https://github.com/jellyfish-dev/react-client-sdk/tree/main/examples/dashboard) example to create room and peer token. | ||
| You u can use [dashboard](https://github.com/jellyfish-dev/jellyfish-dashboard) to create room and peer token. |
No description provided.